Conversation
|
I believe the failure is webpack 5 + ember-data creating a cycle. The debugging is tedious because our add-on tests use JSDom, and JSDom basically throws uncaught exceptions evaluated in itself in a way that isn't much fun for debugging. I am currently going to attempt to confirm my hypothesis, in hopes of identifying a path forward. |
|
diagnosis: embroider-build/embroider#946 It does seem like embroider@0.43.3 fixes the problem in a different way. But it will be good for ember-data to work properly anyways... Let me see whats-up here. |
|
rebasing this now |
ec85e18 to
bfabf52
Compare
|
I believe the fix for the inflector & embroider issue is actually with embroiders inflector compatibility shim -> embroider-build/embroider#948 pending review from @rwjblue or @ef4 |
* reject promise if the evalScripts throws an error * use AssertError to try and provide better test failures * unfortunately errors thrown in JSDoms vmcontext are not provided with a stack. There may be an alternative solution to this, but I am not sure yet. Anyways, this is already better then before.
cc5b195 to
6cc92f1
Compare
|
oh boy, the embroider tests passed!!!!! 🦖 |
No description provided.