MU blueprints: enable EMBER_MODULE_UNIFICATION feature flag#8433
Merged
rwjblue merged 1 commit intoember-cli:masterfrom Feb 14, 2019
Merged
MU blueprints: enable EMBER_MODULE_UNIFICATION feature flag#8433rwjblue merged 1 commit intoember-cli:masterfrom
EMBER_MODULE_UNIFICATION feature flag#8433rwjblue merged 1 commit intoember-cli:masterfrom
Conversation
EMBER_MODULE_UNIFICATION feature flagEMBER_MODULE_UNIFICATION feature flag
Member
The documentation should be updated. When it was originally authored we did use lower case dasherized keys, now we use SCREAMING_SNAKE_CASE. The main reason for the change was that with SCREAMING_SNAKE_CASE we can use them directly as identifiers in javascript/typescript code whereas |
rwjblue
approved these changes
Feb 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to @patricklx for finding and providing the fix of this issue at #8424 (comment)
The MU blueprints were not enabling the
EMBER_MODULE_UNIFICATIONEmber Feature Flag. This PR enables it (I will also add it to the octane blueprints).Relates #8431 and #8424
I have reviewed the Ember code and it looks that there is an issue regarding how Ember Feature Flags works: the Feature Flags doc and guide looks to indicate that the feature key should be in dash and lowercase format, but I could not find in the Ember code that a key transformation from lowercase to uppercase format.
Should it be enabled in lowercase and fix the issue or should the documentation be updated?