Closed
Conversation
06672c0 to
3b14829
Compare
Contributor
|
We have a plan to split this PR in several ones that tackle different MU issues. |
Closed
ppcano
reviewed
Feb 14, 2019
tests/helpers/acceptance.js
Outdated
| options.command = options.command || 'new'; | ||
|
|
||
| return applyCommand(options.command, projectName, '--skip-npm', '--skip-bower', `--directory=${outputDir}`) | ||
| .then(() => isExperimentEnabled('MODULE_UNIFICATION') && getURLFor('canary')) |
Contributor
There was a problem hiding this comment.
This should be fixed by #8432. Thanks for investigating and reporting the issue.
ppcano
suggested changes
Feb 14, 2019
| // Here you can enable experimental features on an ember canary build | ||
| // e.g. 'with-controller': true | ||
| 'ember-module-unification': true | ||
| EMBER_MODULE_UNIFICATION: true |
Contributor
There was a problem hiding this comment.
This should be fixed in a different PR.
This was referenced Feb 14, 2019
Member
|
Needs a rebase, also @ppcano mind doing another review? |
Contributor
|
@rwjblue Yes!, Thank you for looking at it. I am working with @patricklx on these MU changes. We want to merge first #8431, but we will ping you when it is finally ready. |
0a6968b to
ed475eb
Compare
ed475eb to
953aaea
Compare
Contributor
|
MU has been dropped as an initiative. Thanks everyone for your contributions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends on
#8431
will rebase on it