Changes dummy app's detection and project.isModuleUnification()#8158
Closed
NullVoxPopuli wants to merge 4 commits intoember-cli:masterfrom
Closed
Changes dummy app's detection and project.isModuleUnification()#8158NullVoxPopuli wants to merge 4 commits intoember-cli:masterfrom
project.isModuleUnification()#8158NullVoxPopuli wants to merge 4 commits intoember-cli:masterfrom
Conversation
project.isModuleUnification()project.isModuleUnification()
22 tasks
8ff59aa to
51e0964
Compare
Contributor
Author
Contributor
Contributor
Author
|
@ppcano maybe not super long term, but I can see it being incredibly beneficial while we have a bunch of octane and classic apps out in the wild simultaneously. As an addon author, I'd want to be able to verify that if my addon is a classic addon, it'll work with both octane and classic apps, and if my addon is an octane addon, that'll it'll work with octane and classic apps. The matrix of assurance that I want addon authors to be able to complete:
|
Contributor
Author
|
RIP MU |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from the quest issue: emberjs/ember.js#16373
specifically, this partially covers:
proposed scheme for multiple dummy apps: