Skip to content

[WIP] Addons using module unification#7485

Merged
rwjblue merged 2 commits intoember-cli:mu-addonsfrom
stonecircle:master
Dec 6, 2017
Merged

[WIP] Addons using module unification#7485
rwjblue merged 2 commits intoember-cli:mu-addonsfrom
stonecircle:master

Conversation

@mansona
Copy link
Copy Markdown
Member

@mansona mansona commented Dec 4, 2017

Todo:

  • Dry up lib/broccoli/ember-addon.js (copied from lib/broccoli/ember-app.js)
  • Process styles (in some way) from src/ in addon (models/addon.js)
  • fix bad error message for Missing template processor when missing ember-cli-htmlbars in dependecies i.e. it exists in dev-dependencies
  • broccoli-module-unification-reexporter edge cases?
  • throw an error (or do something) when an addon can't decide if it's mu or classic (i.e. has src/ and addon/ or app/ folders)

Tests:

  • _addonSrcTree - ember-app.js
  • _processedVendorTree - test that it includes stuff from the addon src/ folder
  • treeForSrc - models/addon.js
  • addons with src/ folder in classic apps

@rwjblue
Copy link
Copy Markdown
Member

rwjblue commented Dec 6, 2017

Merging into mu-addons branch (aka not master)...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants