Temporarily update blueprint to reduce friction for contributors#8085
Temporarily update blueprint to reduce friction for contributors#8085NullVoxPopuli wants to merge 7 commits intoember-cli:masterfrom
Conversation
|
I wonder why the module unification app and addon blueprint has to use a particular ember-source and ember-cli@master. Shouldn't it mimic the behaviour of classic app blueprint? https://github.com/ember-cli/ember-cli/blob/master/blueprints/app/files/package.json I can create a PR for that |
I think it's just that sometimes things in MU break (since it's not even released). So the hashes specified are known to be working:tm: |
| }, | ||
| "scripts": { | ||
| "build": "ember build", | ||
| "ember": "EMBER_CLI_MODULE_UNIFICATION=true MODULE_UNIFICATION=true ./node_modules/.bin/ember", |
There was a problem hiding this comment.
this env setting style only works in bash. Windows will break.
There was a problem hiding this comment.
cross-env might work for you here.
|
You can use #8219 as a guide to support both yarn and npm. |
kellyselden
left a comment
There was a problem hiding this comment.
I don't have a problem with this dev experience helper for the short term.
|
closed in favor of #8157 and the octane blueprint |
not having the environment flags set is a real "gotchya".
this does create a hard dependency on yarn -- but this is temporary.
These environment variables could move to .ember-cli when
#8059 is merged