Skip to content

change .ember-cli to .ember-cli.js#8157

Closed
NullVoxPopuli wants to merge 3 commits intoember-cli:masterfrom
NullVoxPopuli:update-mu-blueprint
Closed

change .ember-cli to .ember-cli.js#8157
NullVoxPopuli wants to merge 3 commits intoember-cli:masterfrom
NullVoxPopuli:update-mu-blueprint

Conversation

@NullVoxPopuli
Copy link
Copy Markdown
Contributor

@NullVoxPopuli NullVoxPopuli commented Oct 26, 2018

now we don't need package.json shenanigans for MU

@ppcano
Copy link
Copy Markdown
Contributor

ppcano commented Dec 22, 2018

@NullVoxPopuli This change could also be needed in the the MU addon blueprint.

https://github.com/ember-cli/ember-cli/blob/master/blueprints/module-unification-addon/files/.ember-cli

@NullVoxPopuli
Copy link
Copy Markdown
Contributor Author

@ppcano @rwjblue rebased and copied the .ember-cli.js to mu-addon.

questions re: octane

  • will there be a separate ocntane addon blueprint repo like there is for the octane app blueprint?
  • should all the other .ember-cli files change over to .js files?

@ppcano
Copy link
Copy Markdown
Contributor

ppcano commented Dec 25, 2018

will there be a separate ocntane addon blueprint repo like there is for the octane app blueprint?

Can we reuse the ember-octane-blueprint project for both blueprints?

@NullVoxPopuli
Copy link
Copy Markdown
Contributor Author

Unsure. Afaik, remote blueprint packages have a rigid structure, where there is a single files directory at the repo root. I haven't looked at the blueprint resolution code yet, though... So.. idk if it'd be possible. It'd be fantastic if it were though.
I'd also like to use variables and symlinks for a bunch of the duplicate stuff

@Turbo87
Copy link
Copy Markdown
Member

Turbo87 commented Dec 28, 2018

FWIW I'm not a fan of this change. The file currently can be statically parsed by e.g. IDE, which will no longer be the case once we allow JS. IMHO we need stronger reasons to change this than just making a temporary workaround work a little nicer.

@rwjblue
Copy link
Copy Markdown
Member

rwjblue commented Dec 29, 2018

The file currently can be statically parsed by e.g. IDE, which will no longer be the case once we allow JS

FWIW, we already allow .ember-cli.js.

@locks
Copy link
Copy Markdown
Contributor

locks commented Mar 26, 2020

Long live MU! Thanks for the contributions.

@locks locks closed this Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants