Update in-repo-addon blueprint to support module unification#7783
Merged
rwjblue merged 1 commit intoember-cli:masterfrom May 14, 2018
Merged
Update in-repo-addon blueprint to support module unification#7783rwjblue merged 1 commit intoember-cli:masterfrom
in-repo-addon blueprint to support module unification#7783rwjblue merged 1 commit intoember-cli:masterfrom
Conversation
This was referenced Apr 21, 2018
b2ef03c to
12a97f8
Compare
in-repo-addon blueprint to support module unification
12a97f8 to
5bad602
Compare
Contributor
Author
|
/cc @rwjblue |
rwjblue
reviewed
May 14, 2018
| @@ -0,0 +1,4 @@ | |||
| { | |||
Member
There was a problem hiding this comment.
I don't think we should have both a .jshintrc and an .eslintrc, can you remove the .jshintrc.js file?
Contributor
Author
There was a problem hiding this comment.
👍
I should remove this from the lib blueprint too. Happy for me to do this in a follow on PR so that this remains focused?
| @@ -0,0 +1,6 @@ | |||
| module.exports = { | |||
Member
There was a problem hiding this comment.
Generally speaking, we should not be adding .eslintrc.js files, instead we should rely on overrides configuration in the top level eslintrc.
Contributor
Author
There was a problem hiding this comment.
I'm following the pattern of the existing lib blueprint. I can follow this PR up with changes to both lib and packages to replay on overrides
rwjblue
approved these changes
May 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #7530
This PR updates the
in-repo-addonblueprint to generate an in-repo addon in thepackagesdirectory when the app is MU. It also introduces a newpackagesblueprint which will be the successor to the classiclibblueprint.TODO: