[wip] Change confirmBlueprinted to test against fixtures#7557
Closed
ro0gr wants to merge 24 commits intoember-cli:masterfrom
Closed
[wip] Change confirmBlueprinted to test against fixtures#7557ro0gr wants to merge 24 commits intoember-cli:masterfrom
ro0gr wants to merge 24 commits intoember-cli:masterfrom
Conversation
ro0gr
commented
Jan 14, 2018
tests/acceptance/new-test.js
Outdated
| 'foo', | ||
| '--skip-npm', | ||
| '--skip-bower', | ||
| '--no-welcome', |
Contributor
Author
There was a problem hiding this comment.
currently we have welcome only in yarn fixtures. This forces me to disable welcome when I test w/o yarn. I think we should decouple testing of welcome from yarn and drop all of this extra --no-welcome flags for npm tests.
Contributor
Author
Contributor
Author
|
Currently I'm not sure what do CI failures try to tell me. I've tested it locally on both windows and macos machines and tests pass. Maybe it's a call to improve a fixtures diff error message... 🤔 |
- make fixtures unaware of --no-welcome flag
it allows to drop module-unification-app fixture files by reusing app's fixture
Contributor
Author
|
see #7595 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When worked on MU blueprints improvements I've noticed that the current
confirmBlueprintedis not a very suitable tool for testing of blueprints because:This pr tries to address these issues by testing of
newandaddoncommands output against the fixtures. I've chosenfixturifyto deal with fixtures. It seems quite a convenient tool cause it efficiently serializes fs layout including file contents into a POJOs which allows us to make deep equals with ease.I would appreciate a feedback before I've gone too far. Does it look like a good direction?
TODO:
expectProjecttests and "verify fixtures" tests.addlodash.{get,set}toember-cli-lodash-subsetworked around by flattening
fixturifyresultsmodule-unification-appfixture files by re-using app's project files