Closed
Conversation
3 tasks
ro0gr
commented
Dec 12, 2017
|
|
||
| filesToRemove: [], | ||
|
|
||
| ignoredFilePaths: [ |
Contributor
Author
There was a problem hiding this comment.
I feel ignoredFilePaths wants to be a part of fileMap, each key with a null value. Unfortunately Blueprint model exects fileMap values to be string only.
Member
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr tries to reduce amount of MU blueprint files introduced in #7488 .
Here used the same approach as in the addon blueprint.
Potentially we could get rid of "blueprints/module-unification-app/files/package.json" as well but not for now.
Tests are failing due to the usage of confirmBlueprintForDir which doesn't seem as a suitable tool for checking composed blueprints.
I think the test has to be changed to check generator output against MU fixture. Does it sound reasonable? Would appreciate any pointers for the test improvements.