Skip to content

Update to QUnit 2.0 compatible output.#3197

Merged
rwjblue merged 2 commits intoember-cli:masterfrom
rwjblue:update-to-qunit-2-0-compat
Feb 4, 2015
Merged

Update to QUnit 2.0 compatible output.#3197
rwjblue merged 2 commits intoember-cli:masterfrom
rwjblue:update-to-qunit-2-0-compat

Conversation

@rwjblue
Copy link
Copy Markdown
Member

@rwjblue rwjblue commented Feb 3, 2015

See http://qunitjs.com/upgrade-guide-2.x/ for more details.

Closes #3196.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this and the other places need to be QUnit.test ?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test is imported from ember-qunit here, so no.

@jakecraige
Copy link
Copy Markdown
Member

You missed a lot of test => QUnit.test and a few module => QUnit.module

@rwjblue rwjblue force-pushed the update-to-qunit-2-0-compat branch from b1c0572 to c35e358 Compare February 4, 2015 01:53
@chadhietala
Copy link
Copy Markdown
Member

Restarting travis but looks good to me.

@rwjblue rwjblue force-pushed the update-to-qunit-2-0-compat branch from a7568ee to 4c7a8fc Compare February 4, 2015 12:18
rwjblue added a commit that referenced this pull request Feb 4, 2015
Update to QUnit 2.0 compatible output.
@rwjblue rwjblue merged commit 85ff84e into ember-cli:master Feb 4, 2015
@rwjblue rwjblue deleted the update-to-qunit-2-0-compat branch February 4, 2015 13:12
clekstro added a commit to fauxton/travis-web that referenced this pull request Jan 31, 2016
As noted in [this
issue](ember-cli/ember-cli#3197),
assert is now to be prepended to assertions and passed in to
the test function.

This commit was generated by ember-watson.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update test blueprint module setup/teardown to keep up to date with qunit

4 participants