Skip to content

Added support for parallel instances saving to same directory#24

Merged
elmoiv merged 1 commit intoelmoiv:masterfrom
mwargan:master
Mar 9, 2022
Merged

Added support for parallel instances saving to same directory#24
elmoiv merged 1 commit intoelmoiv:masterfrom
mwargan:master

Conversation

@mwargan
Copy link
Copy Markdown
Contributor

@mwargan mwargan commented Mar 8, 2022

No description provided.

@mwargan
Copy link
Copy Markdown
Contributor Author

mwargan commented Mar 8, 2022

Hey - this pull request updates the handling of the temp directory - when I ran multiple instances of the downloader that all saved to the same directory, the temp generic file names had overriden each other while saving and mixing audio and video from multiple sources.

This pull request fixes this issue, and allows multiple instances downloading to the same directory at the same time to not have clashes with each other over the temp directory.

@elmoiv elmoiv merged commit 7c69e30 into elmoiv:master Mar 9, 2022
@elmoiv
Copy link
Copy Markdown
Owner

elmoiv commented Mar 9, 2022

Thanks @mwargan for your contribution.

Your implementation solves parallel instances issue but leaves 'temp' folder not deleted.
I will create a clean_temp method that will be useful to call after all threads are done.

@elmoiv elmoiv added the enhancement New feature or request label Mar 9, 2022
elmoiv added a commit that referenced this pull request Mar 9, 2022
- Added redvid as a console script "credvid.py" no longer needed.
- Merged #24 (Parallel Instances)
- Added `clean_temp` method and updated its argument in console mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants