Wrap fastembed in try catch to allow non node environments to build#508
Merged
Conversation
mcp97
approved these changes
Nov 22, 2024
mcp97
left a comment
Contributor
There was a problem hiding this comment.
LGTM - thanks for getting this out!
lalalune
pushed a commit
that referenced
this pull request
May 3, 2026
Wrap `fastembed` in try catch to allow non node environments to build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to: #507
Non node.js environments may have issues building because of some packages and how they are imported.
##To Reproduce
Make a worker, include eliza/core and attempt to build. It will throw an error similar to
✘ [ERROR] No loader is configured for ".node" files:
node_modules/@anush008/tokenizers-darwin-universal/tokenizers.darwin-universal.node
Expected behavior
This PR wraps the import in try catch to gracefully fail and allow the build.