fix: crash on http server use #1671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6617f8e to
ad9b548
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1671 +/- ##
=======================================
Coverage 40.62% 40.62%
=======================================
Files 798 798
Lines 37774 37769 -5
Branches 5385 5382 -3
=======================================
+ Hits 15344 15345 +1
+ Misses 20606 20600 -6
Partials 1824 1824
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
28327b9 to
961069d
Compare
Signed-off-by: Dario Valdespino <dvaldespino00@gmail.com>
Signed-off-by: Dario Valdespino <dvaldespino00@gmail.com>
Signed-off-by: Dario Valdespino <dvaldespino00@gmail.com>
Signed-off-by: Dario Valdespino <dvaldespino00@gmail.com>
961069d to
1c6db1f
Compare
sgammon
approved these changes
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #1670 and restores minimal functionality to Elide's HTTP server intrinsics:
Contextinstances are now correctly attached to anEngine. This behavior is disabled by default when acquiring a new context from a CLI command usingresolvePolyglotContext(), to avoid breaking existing code; it can be enabled by passingdetached = false.NettyHttpResponse.from(...)builder function now returns a new empty mutable response; it was previously unimplemented.In general, the
servecommand should now work again, though some features are still unimplemented (coming soon).Important
The old
expressintrinsics are no longer available,Elide.httpshould be used instead. Support for express-like APIs and a drop-in express.js replacement may be added in the near future.