Skip to content

Add codiepie, deviantart, freecodecamp and gitlab to Social Icons Widget#5820

Closed
ipokkel wants to merge 32 commits intoelementor:release/2.3.0from
ipokkel:master
Closed

Add codiepie, deviantart, freecodecamp and gitlab to Social Icons Widget#5820
ipokkel wants to merge 32 commits intoelementor:release/2.3.0from
ipokkel:master

Conversation

@ipokkel
Copy link
Copy Markdown
Contributor

@ipokkel ipokkel commented Sep 28, 2018

Added extra social icons to the Social Icons Widget for developers (codepie, gitlab), designers (deviantart) and students (freecodecamp).
See Feature request: #5816

PR Checklist

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Summary

This PR can be summarized in the following changelog entry:

Description

An explanation of what is done in this PR

Test instructions

This PR can be tested by following these steps:

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended
  • Docs have been added / updated (for bug fixes / features)

Fixes #

joshmarom and others added 30 commits September 12, 2018 15:17
Added Compatibility for Gutenberg Image Block
Revert Gutenberg Image Block compatibility
KingYes and others added 2 commits September 20, 2018 19:33
Added extra social icons to the Social Icons Widget for developers (codepie, gitlab), designers (deviantart) and students (freecodecamp).
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Sep 28, 2018

CLA assistant check
All committers have signed the CLA.

@arielk arielk added this to the 2.3.0 milestone Sep 30, 2018
@KingYes KingYes changed the base branch from master to release/2.3.0 October 2, 2018 14:13
@KingYes
Copy link
Copy Markdown
Member

KingYes commented Oct 3, 2018

@ipokkel
I don't know why Github show me all old commits in this PR. Can you create new PR from release/2.3.0 branch?

@ipokkel
Copy link
Copy Markdown
Contributor Author

ipokkel commented Oct 4, 2018

@KingYes I've added a PR to 2.3.0. #5847

Hope this works better for you

@ipokkel
Copy link
Copy Markdown
Contributor Author

ipokkel commented Oct 4, 2018

Closing this PR as new one submitted for v2.3.0 that passes all ci tests.
#5847

@ipokkel ipokkel closed this Oct 4, 2018
arielk added a commit that referenced this pull request Oct 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants