Skip to content

fix(components): inconsistent style rounded button#14552

Merged
tolking merged 1 commit intoelement-plus:devfrom
cuongle-hdwebsoft:fix-rounded-button
Oct 15, 2023
Merged

fix(components): inconsistent style rounded button#14552
tolking merged 1 commit intoelement-plus:devfrom
cuongle-hdwebsoft:fix-rounded-button

Conversation

@cuongle-hdwebsoft
Copy link
Copy Markdown
Contributor

@cuongle-hdwebsoft cuongle-hdwebsoft commented Oct 15, 2023 •
edited
Loading

fix: inconsistent style rounded button

closed #14550

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Description

🤖 Generated by Copilot at 873a0c7

Fix button size inconsistency across browsers by aligning button width with default input height in button.scss.

Related Issue

Fixes #14550.

Explanation of Changes

🤖 Generated by Copilot at 873a0c7

  • Fix inconsistent button sizes in different browsers by:
    • Setting button width to match default input height (link)

fix(components): fix: inconsistent style rounded button
873a0c7 
fix: inconsistent style rounded button

closed element-plus#14550
@pull-request-triage
Copy link
Copy Markdown

pull-request-triage bot commented Oct 15, 2023

👋 @cuongle-hdwebsoft, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 15, 2023 •
edited
Loading

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 15, 2023

Hello @cuongle-hdwebsoft, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 15, 2023

🧪 Playground Preview: https://element-plus.run/?pr=14552
Please comment the example via this playground if needed.

@cuongle-hdwebsoft
Copy link
Copy Markdown
Contributor Author

cuongle-hdwebsoft commented Oct 15, 2023

Before: demo link
CleanShot 2023-10-15 at 14 16 14@2x

After: demo link
CleanShot 2023-10-15 at 14 15 57@2x

@cuongle-hdwebsoft cuongle-hdwebsoft changed the title fix(components): fix: inconsistent style rounded button fix(components): inconsistent style rounded button Oct 15, 2023
btea
btea approved these changes Oct 15, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tolking tolking merged commit 0e9cade into element-plus:dev Oct 15, 2023
cc-hearts pushed a commit to cc-hearts/element-plus that referenced this pull request Oct 15, 2023
@cuongle-hdwebsoft @cc-hearts
fix(components): inconsistent style rounded button (element-plus#14552)
833b0ba 
fix(components): fix: inconsistent style rounded button

fix: inconsistent style rounded button

closed element-plus#14550
@element-bot element-bot mentioned this pull request Oct 18, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tolking tolking tolking approved these changes

@btea btea btea approved these changes

Assignees

@cuongle-hdwebsoft cuongle-hdwebsoft

Labels

CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Style] [button] row加上按钮为圆形会变扁

3 participants

@cuongle-hdwebsoft @tolking @btea