Merged
Conversation
piotrpdev
commented
Jul 2, 2024
dsanders11
reviewed
Jul 4, 2024
dsanders11
reviewed
Jul 4, 2024
dsanders11
reviewed
Jul 4, 2024
erickzhao
approved these changes
Jul 30, 2024
18 tasks
Reported-by: David Sanders <dsanders11@ucsbalum.com>
dsanders11
reviewed
Aug 9, 2024
dsanders11
reviewed
Aug 10, 2024
Member
dsanders11
left a comment
There was a problem hiding this comment.
Added a couple of suggestions to simplify the code.
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com> Based-on-patch-by: David Sanders <dsanders11@ucsbalum.com> Reference: #594 (comment)
dsanders11
approved these changes
Aug 12, 2024
Member
|
I think this is ready. 🎉 @piotrpdev, can you go ahead and remove the |
`git diff feat/api-history origin/main -- docs/latest/api/ | git apply`
Contributor
Author
Done, hopefully nothing breaks on merge 🤞 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This PR is part of the 2024 Electron GSoC [Project] [Proposal].
Use
export GH_TOKEN=<token>beforeyarn startif you want to test the releases fetching and unzipping.You might have to manually modify
sidebars.jsto makeyarn startwork.Note
In development mode, clicking on one of the breaking changes in the table will open the correct page but not jump to the linked header. This is an issue with Docusaurus.
TODO
docs/api/*.mdbefore merge, they're just for previewing/testing the PR.src/transformers/api-history.tshttps://github.com/electron/website/pull/594/files#diff-1150b9be07a8f0d779823f74f0403681feb5bc13bfda0a500edeadd81a8ce61cR94-R113Replace fetching the PR release versions artifact with fetching a JSON file once @dsanders11 implements that.Won't happen for a while, will merge withGH_TOKEN.