ci: temporary workflow to resolve Electron release versions for PRs#586
Merged
dsanders11 merged 2 commits intomainfrom Jun 26, 2024
Merged
ci: temporary workflow to resolve Electron release versions for PRs#586dsanders11 merged 2 commits intomainfrom
dsanders11 merged 2 commits intomainfrom
Conversation
113e6d6 to
a6572e1
Compare
erickzhao
approved these changes
Jun 26, 2024
VerteDinde
approved these changes
Jun 26, 2024
Member
VerteDinde
left a comment
There was a problem hiding this comment.
Looks good! One nit question
| const getBackportPattern = () => | ||
| /(?:^|\n)(?:manual |manually )?backport (?:of )?(?:#(\d+)|https:\/\/github.com\/.*\/pull\/(\d+))/gim; | ||
|
|
||
| const BOOTSTRAP_DATA_URL = 'https://gist.githubusercontent.com/dsanders11/eb51a04d04a6a3e0710d88db5250e698/raw/fd960b6dea1152b55427407646044f1ba187e52b/data.json'; |
Member
There was a problem hiding this comment.
I am incredibly nitting here, but do we want to pop this into an Electron repo somewhere? If we think this will actually be pretty temporary, I'm okay leaving it
Member
Author
There was a problem hiding this comment.
It's a valid point to raise! I'm definitely intending for this workflow overall to be pretty temporary (pending practical realities getting int he way), but this line in particular can be super temporary. Once we merge and have one run of the workflow to store an artifact, this line can be removed entirely as the bootstrap step will be complete and shouldn't (unless artifacts somehow all got jettisoned) be needed again.
This was referenced Jul 9, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a temporary workflow in support of @piotrpdev's Google Summer of Code work. Long-term this will be removed from this repo and the code will be refactored to live on
electron/release-status, but for now this is the easiest place to put it such that it can be used immediately. Since it is temporary I've kept it isolated entirely to this one file so it doesn't affect anything else in this repo.Example snippet of how to fetch the content from the latest workflow run is included below. Requires a GitHub token with
actions: readperms onelectron/websiterepo.