This repository was archived by the owner on Jan 6, 2023. It is now read-only.
Conversation
8548556 to
749e507
Compare
423732e to
5fe3812
Compare
d74b612 to
a73dca5
Compare
5fe3812 to
5d784eb
Compare
7f4ad03 to
22c7269
Compare
deepak1556
reviewed
Dec 19, 2017
| #include <memory> | ||
| #include <string> | ||
|
|
||
| +#include "v8.h" |
Member
There was a problem hiding this comment.
Can we have the V8_EXPORT declarations moved out to a separate file v8-export.h and include it in v8.h and v8-platform.h instead ?
Contributor
Author
There was a problem hiding this comment.
@deepak1556 I believe that patches should be as small as possible to minimise the maintenance cost.
V8_EXPORTdeclarations moved out to a separate filev8-export.h
It probably makes sense, but it should be done in the upstream V8 repo.
da6ebb8 to
1d5f62f
Compare
8b80657 to
d488238
Compare
1d5f62f to
86a8670
Compare
3d3957d to
1e5286a
Compare
16ee275 to
5964d8f
Compare
5cb70dc to
322eb12
Compare
c242982 to
b0ad0ee
Compare
d56978a to
6c17428
Compare
It's already there.
The patch is already there as 027-backport_a2b91ed.patch
The patch is already there as 026-backport_3ecb047.patch.
Got crash in Electron: [22964:0312/160427.139779:FATAL:V8PerIsolateData.cpp(54)] Check failed: !ScriptForbiddenScope::IsScriptForbidden(). 0 0x7f52de54eb2d base::debug::StackTrace::StackTrace() 1 0x7f52de54cf5c base::debug::StackTrace::StackTrace() 2 0x7f52de5d3dba logging::LogMessage::~LogMessage() 3 0x7f52e10ddd40 <unknown> 4 0x7f52ee73c505 <unknown> 5 0x7f52ee75e938 v8::Function::Call() 6 0x7f52ef0c9c61 node::InternalMakeCallback() 7 0x7f52ef0ca0ae node::MakeCallback() 8 0x7f52ef0c9ff4 node::MakeCallback() 9 0x7f52ef0c9ec2 node::MakeCallback() 10 0x000000e5e617 mate::internal::CallMethodWithArgs() 11 0x000000fc3f61 _ZN4mate9EmitEventIA15_cJEEEN2v85LocalINS2_5ValueEEEPNS2_7IsolateENS3_INS2_6ObjectEEERKT_DpRKT0_ 12 0x000000fc2c6f atom::AtomRendererClient::RunScriptsAtDocumentStart() 13 0x7f52db3390eb content::RenderFrameImpl::RunScriptsAtDocumentElementAvailable()
a78780f to
b284093
Compare
MarshallOfSound
approved these changes
Mar 20, 2018
zcbenz
approved these changes
Mar 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
63.0.3239.150
Electron PR: electron/electron#11459
Project board: https://github.com/electron/electron/projects/7