Skip to content

Upgrade to Chromium 63#11459

Merged
zcbenz merged 98 commits intomasterfrom
upgrade-to-chromium-63
Mar 20, 2018
Merged

Upgrade to Chromium 63#11459
zcbenz merged 98 commits intomasterfrom
upgrade-to-chromium-63

Conversation

@alexeykuzmin
Copy link
Copy Markdown
Contributor

@alexeykuzmin alexeykuzmin commented Dec 17, 2017 •
edited
Loading

@alexeykuzmin alexeykuzmin requested review from a team December 17, 2017 21:32
@alexeykuzmin alexeykuzmin changed the base branch from master to upgrade-to-chromium-62 December 17, 2017 21:32
@alexeykuzmin alexeykuzmin mentioned this pull request Dec 18, 2017
Merged
@jarek-foksa
Copy link
Copy Markdown

jarek-foksa commented Dec 19, 2017

Is there going to be any release based on Chromium 61 or 62? Or are you planning to skip them and release Electron 2.0 when Chromium 63 upgrade is finished?

@alexeykuzmin
Copy link
Copy Markdown
Contributor Author

alexeykuzmin commented Dec 19, 2017

Is there going to be any release based on Chromium 61 or 62?

@jarek-foksa Probably. Maybe. No promises. Stay tuned.

@bbert
Copy link
Copy Markdown

bbert commented Dec 20, 2017

Hi,
Will you also provide afterwards a version with chrome 64?
Since chrome 64 will provide license persistency, that will be worthy to have it in Electron.

@alexeykuzmin
Copy link
Copy Markdown
Contributor Author

alexeykuzmin commented Dec 20, 2017

Will you also provide afterwards a version with chrome 64?

Hi, @bbert
We will definitely provide a version of Electron with Chromium 64 or newer in the future.

@zcbenz zcbenz force-pushed the upgrade-to-chromium-62 branch from d2eb942 to 8510778 Compare December 27, 2017 13:01
@alexeykuzmin alexeykuzmin force-pushed the upgrade-to-chromium-63 branch from 6c1c37f to 7127b81 Compare January 2, 2018 02:15
@deepak1556 deepak1556 force-pushed the upgrade-to-chromium-63 branch 2 times, most recently from aa7e2b0 to 9d001c7 Compare January 2, 2018 11:23
@kossmoboleat kossmoboleat mentioned this pull request Jan 3, 2018
Open
@alexeykuzmin alexeykuzmin force-pushed the upgrade-to-chromium-62 branch from 0aa29ce to b45fb4d Compare January 5, 2018 05:47
@alexeykuzmin alexeykuzmin force-pushed the upgrade-to-chromium-63 branch 2 times, most recently from b2fa8e1 to 02b6e2e Compare January 11, 2018 22:52
@FrogTheFrog FrogTheFrog mentioned this pull request Jan 21, 2018
Closed
@PalmerAL PalmerAL mentioned this pull request Jan 21, 2018
Closed
@setpixel
Copy link
Copy Markdown

setpixel commented Jan 25, 2018

Hi guys 👍

I know the answer is: when it's done.

But do you have a very rough goal of when there will be a release with a chromium beyond 59? 💃

❤️ ❤️ ❤️ ❤️ ❤️ ❤️

@alexeykuzmin
Copy link
Copy Markdown
Contributor Author

alexeykuzmin commented Jan 25, 2018

@setpixel Soon.

@jasonblais jasonblais mentioned this pull request Jan 26, 2018
Closed
3 tasks
@zcbenz zcbenz force-pushed the upgrade-to-chromium-62 branch from e805994 to c89c26a Compare January 31, 2018 07:09
@MarshallOfSound MarshallOfSound mentioned this pull request Jan 31, 2018
Closed
@wis
Copy link
Copy Markdown

wis commented Jan 31, 2018

hoping it's a Chromium version >= 64.0.3240.0, so puppeteer (which uses DevTools Protocol) can work with it.
electron-userland/spectron#240

@alexeykuzmin
Copy link
Copy Markdown
Contributor Author

alexeykuzmin commented Feb 5, 2018

@wesamco Sorry, but the next release will probably have Chromium 61.

@taha
Copy link
Copy Markdown

taha commented Feb 6, 2018 •
edited
Loading

@alexeykuzmin I'm quite confused. I'm working on a private folk of Electron at the moment. Back then when I was starting I thought it would be a good idea to folk it from 1-8-x. It had Chromium 61. Now I rebased 1.8.2-beta.5, and it uses Chromium 59. Will it revert back to 61 before the actual release of 1.8.2?

(Edit: I figured out the Chromium version for the VERSION file in the libchromiumcontent repo)

@alexeykuzmin
Copy link
Copy Markdown
Contributor Author

alexeykuzmin commented Feb 11, 2018

@taha 1-8-x branch has never had Chromium 61.
You probably had the vendor/libchromiumcontent submodule out of sync.

@petrbrzek
Copy link
Copy Markdown

petrbrzek commented Feb 16, 2018

@alexeykuzmin any ETA for this? Also what about #11230, is it going to be closed?

@alexeykuzmin
Copy link
Copy Markdown
Contributor Author

alexeykuzmin commented Feb 16, 2018

@petrbrzek No ETA. Chromium 62 is going to be merged and released before Chromium 63.

alexeykuzmin and others added 25 commits March 20, 2018 10:13
@alexeykuzmin
Tab Capture in VIZ: CopyOutputRequest/Result API changes.
d3afb59 
https://chromium-review.googlesource.com/637003
@alexeykuzmin
Use visual studio 17 image
d90b600
@alexeykuzmin
Add whole appveyor config
d58b366
@alexeykuzmin
Drop clone folder
dfc4dbd
@alexeykuzmin
debug build issues
750c3d0
@alexeykuzmin
spec: Do not assume en-US locale to be the current
d5ecbfc
@zcbenz @alexeykuzmin
Fix release build on Windows
246f631
@deepak1556 @alexeykuzmin
Enable node crypto spec
f9de29e
@deepak1556 @alexeykuzmin
REVIEW: ContentBrowserClient now provides geolocation api key and req…
97eb7f2 
…uest context
@deepak1556 @alexeykuzmin
AccessTokenStore is only needed to initialize network location service
9702898
@zcbenz @alexeykuzmin
Use 60 as module version for V8 6.3
cb4c54e
@zcbenz @alexeykuzmin
Update chrome_version.h
97fcf70
@deepak1556 @alexeykuzmin
re-use request context from IOThread
c3f8f6b
@zcbenz @alexeykuzmin
Emit document-start for the correct env
94fce43 
This fixes the crash in RunScriptsAtDocumentStart when "affinity" option
is specified. Previously we were assuming only one main frame exists in
the renderer process, but the "affinity" option breaks this option.

There is also a bug that "node::Environment::GetCurrent" does not return
nullptr for context without a env in it, I'm not sure whether it is a
bug of Node or V8.
@alexeykuzmin
Update to the latest libcc with Ch63
714a793
@alexeykuzmin
Remove custom appveyor config
6aebae5
@deepak1556 @alexeykuzmin
Fix windows build
c190814
@deepak1556 @alexeykuzmin
move pdf viewer behind feature flag
4b39d17
@deepak1556 @alexeykuzmin
add features module to detect availability of build time features at …
e24c0dd 
…runtime
@deepak1556 @alexeykuzmin
FIXME: disable pdf viewer feature
f5e1ee0
@zcbenz @alexeykuzmin
Avoid including web_contents_impl.h
d496978 
This can fix the build error caused by duplicate typedefs.
@gerhardberger @alexeykuzmin
fixes offscreen rendering issues
0ad8815
@gerhardberger @alexeykuzmin
fixes class name
a9cdd66
@zcbenz @alexeykuzmin
Isolate the code using content::WebContentsImpl
2e94a73
@zcbenz @alexeykuzmin
Ignore warning LNK4199
c701508 
We are now sharing the /DELAYLOAD settings between configurations.
@alexeykuzmin alexeykuzmin force-pushed the upgrade-to-chromium-63 branch from 9ee0ed5 to c701508 Compare March 20, 2018 07:13
@zcbenz zcbenz merged commit cd30a4e into master Mar 20, 2018
@zcbenz zcbenz deleted the upgrade-to-chromium-63 branch March 20, 2018 08:25
@andens andens mentioned this pull request Mar 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@poiru poiru poiru left review comments

@zeke zeke zeke approved these changes

@zcbenz zcbenz zcbenz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.