This repository was archived by the owner on Jan 6, 2023. It is now read-only.
Stop using experimental allocator shim on win32#289
Merged
kevinsawicki merged 1 commit intomasterfrom May 9, 2017
Merged
Conversation
It is causing electron.exe and node.dll to use different allocators, this is fine in Chromium becuase everything has been compiled into the same exe, while in Electron lots of components have been put into node.dll and we have to make sure electron.exe and node.dll use the same allocator.
Contributor
|
👍 Retriggered the linux builds and they are passing |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is causing electron.exe and node.dll to use different allocators, this is fine in Chromium becuase everything has been compiled into the same exe, while in Electron lots of components have been put into node.dll and we have to make sure electron.exe and node.dll use the same allocator.
This is to fix the crash in electron/electron#9116.