Upgrade to Chrome 58 by zcbenz · Pull Request #9116 · electron/electron

zcbenz · 2017-04-05T10:54:55Z

Debug build compiles on:

OS X
Linux
Windows

Release build compiles on:

OS X
Linux
Windows

Tests passing on:

OS X
Linux
Windows

Merge:

bbondy · 2017-04-24T03:24:04Z

atom/common/native_mate_converters/blink_converter.cc

  if (dict.Get("canScroll", &can_scroll) && !can_scroll) {
    out->hasPreciseScrollingDeltas = false;
-    out->modifiers &= ~blink::WebInputEvent::ControlKey;
+    out->setModifiers(out->modifiers() | blink::WebInputEvent::ControlKey);


Is this logic intentionally changed? It is not equivalent.
Before it keeps all flags except for ControlKey, and now it adds ControlKey flag

It is a mistake, thanks for finding it out!

The latter is removing some APIs we use.

zcbenz · 2017-04-27T10:03:52Z

I have updated Node to v7.9.0 and increased node module version. The tests of native modules are failing because of the bumping of node module version.

This PR should be ready to merge, though I would expect to see unknown regressions due to Chrome and Node upgrade.

kevinsawicki · 2017-05-02T17:15:33Z

The tests of native modules are failing because of the bumping of node module version.

I've updated this branch to build the spec modules against a local headers tarball instead of a published one so hopefully this shouldn't happen again going forward when we bump the node module version.

kevinsawicki · 2017-05-03T00:11:16Z

Seeing some crashes from LocalArrayBufferTracker on Windows, also seen by @brenca:

   ntdll.dll!_RtlReportCriticalFailure@12()    Unknown
    ntdll.dll!_RtlpReportHeapFailure@4()    Unknown
    ntdll.dll!_RtlpHeapHandleError@4()  Unknown
    ntdll.dll!_RtlpLogHeapFailure@24()  Unknown
    ntdll.dll!_RtlFreeHeap@12() Unknown
    electron.exe!base::allocator::WinHeapFree(void *)   Unknown
    electron.exe!base::debug::Alias(void const *)   Unknown
    electron.exe!_free()    Unknown
    electron.exe!gin::ArrayBufferAllocator::Free(void * data, unsigned int length) Line 34  C++
    node.dll!v8::internal::LocalArrayBufferTracker::Process<<lambda_364280a90984476bdb46fa9c7db4695b> >(v8::internal::ArrayBufferTracker::ProcessBuffers::__l2::<lambda_364280a90984476bdb46fa9c7db4695b> callback) Line 66   C++
    node.dll!v8::internal::ArrayBufferTracker::FreeDeadInNewSpace(v8::internal::Heap * heap) Line 82    C++
    node.dll!v8::internal::Heap::Scavenge() Line 1773   C++
    node.dll!v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector collector, const v8::GCCallbackFlags gc_callback_flags) Line 1359  C++
    node.dll!v8::internal::Heap::CollectGarbage(v8::internal::GarbageCollector collector, v8::internal::GarbageCollectionReason gc_reason, const char * collector_reason, const v8::GCCallbackFlags gc_callback_flags) Line 1013    C++

Seems to occur possibly on the first GC in the main process, can reproduce pretty consistently by requiring a large library. Seeing it when running the specs on Windows against the release build when electabul gets required which in turn requires asar.

Will investigate further and try to narrow down.

Here is another one:

 	ntdll.dll!RtlFreeHeap�()	Unknown
 	electron.exe!base::allocator::WinHeapFree(void *)	Unknown
 	node.dll!v8::internal::LocalArrayBufferTracker::Process<<lambda_d5761fd40aa45311e3047f5db5a671ca> >(v8::internal::ArrayBufferTracker::ProcessBuffers::__l2::<lambda_d5761fd40aa45311e3047f5db5a671ca> callback) Line 67	C++
 	node.dll!v8::internal::ArrayBufferTracker::FreeDeadInNewSpace(v8::internal::Heap * heap) Line 82	C++
 	node.dll!v8::internal::Heap::Scavenge() Line 1773	C++
 	node.dll!v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector collector, const v8::GCCallbackFlags gc_callback_flags) Line 1359	C++
 	node.dll!v8::internal::Heap::CollectGarbage(v8::internal::GarbageCollector collector, v8::internal::GarbageCollectionReason gc_reason, const char * collector_reason, const v8::GCCallbackFlags gc_callback_flags) Line 1013	C++
 	node.dll!v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace space, v8::internal::GarbageCollectionReason gc_reason, const v8::GCCallbackFlags callbackFlags) Line 686	C++
 	node.dll!v8::internal::Factory::NewRawOneByteString(int length, v8::internal::PretenureFlag pretenure) Line 539	C++
 	node.dll!v8::internal::String::SlowFlatten(v8::internal::Handle<v8::internal::ConsString> cons, v8::internal::PretenureFlag pretenure) Line 2444	C++
 	node.dll!v8::internal::String::Flatten(v8::internal::Handle<v8::internal::String> string, v8::internal::PretenureFlag pretenure) Line 3534	C++
 	node.dll!v8::internal::Parser::ParseProgram(v8::internal::Isolate * isolate, v8::internal::ParseInfo * info) Line 626	C++
 	node.dll!v8::internal::parsing::ParseProgram(v8::internal::ParseInfo * info, bool internalize) Line 30	C++
 	node.dll!v8::internal::`anonymous namespace'::CompileToplevel(v8::internal::CompilationInfo * info) Line 1157	C++
 	node.dll!v8::internal::Compiler::GetSharedFunctionInfoForScript(v8::internal::Handle<v8::internal::String> source, v8::internal::Handle<v8::internal::Object> script_name, int line_offset, int column_offset, v8::ScriptOriginOptions resource_options, v8::internal::Handle<v8::internal::Object> source_map_url, v8::internal::Handle<v8::internal::Context> context, v8::Extension * extension, v8::internal::ScriptData * * cached_data, v8::ScriptCompiler::CompileOptions compile_options, v8::internal::NativesFlag natives) Line 1764	C++
 	node.dll!v8::ScriptCompiler::CompileUnboundInternal(v8::Isolate * v8_isolate, v8::ScriptCompiler::Source * source, v8::ScriptCompiler::CompileOptions options) Line 2151	C++
 	node.dll!v8::ScriptCompiler::CompileUnboundScript(v8::Isolate * v8_isolate, v8::ScriptCompiler::Source * source, v8::ScriptCompiler::CompileOptions options) Line 2188	C++
>	node.dll!node::ContextifyScript::New(const v8::FunctionCallbackInfo<v8::Value> & args) Line 533	C++
 	node.dll!v8::internal::FunctionCallbackArguments::Call(void(*)(const v8::FunctionCallbackInfo<v8::Value> &) f) Line 26	C++
 	node.dll!v8::internal::`anonymous namespace'::HandleApiCallHelper<1>(v8::internal::Isolate * isolate, v8::internal::Handle<v8::internal::HeapObject> function, v8::internal::Handle<v8::internal::HeapObject> new_target, v8::internal::Handle<v8::internal::FunctionTemplateInfo> fun_data, v8::internal::Handle<v8::internal::Object> receiver, v8::internal::BuiltinArguments args) Line 113	C++
 	node.dll!v8::internal::Builtin_Impl_HandleApiCall(v8::internal::BuiltinArguments args, v8::internal::Isolate * isolate) Line 136	C++
 	node.dll!v8::internal::Builtin_HandleApiCall(int args_length, v8::internal::Object * * args_object, v8::internal::Isolate * isolate) Line 128	C++

kevinsawicki · 2017-05-08T17:26:18Z

Was able to track down the crash a bit more, here is a simpler reproduction:

const crypto = require('crypto')

for (let i = 1; i < 10000; i++) {
  crypto.randomBytes(i)
}

This crashes for me each time

For Buffers created in Node, they are usually allocated in Node and freed by Chromium's allocator, which will cause crashes when Node and Chromium are using different allocators. This commit makes Chromium use Node' allocator for ArrayBuffers.

zcbenz · 2017-05-09T06:14:34Z

I have pushed a fix for the crash in the main process, however when taking a heap snapshot in devtools, a crash would happen in renderer process:

 	ntdll.dll!00007ffbd39c1b70()	Unknown
 	ntdll.dll!00007ffbd39c4db2()	Unknown
 	ntdll.dll!00007ffbd39c59b0()	Unknown
 	ntdll.dll!00007ffbd397a810()	Unknown
 	node.dll!_free_base(void * block) Line 112	C++
 	[External Code]	
>	node.dll!v8::internal::NativeObjectsExplorer::FillRetainedObjects() Line 2312	C++
 	node.dll!v8::internal::NativeObjectsExplorer::IterateAndExtractReferences(v8::internal::SnapshotFiller * filler) Line 2354	C++
 	node.dll!v8::internal::HeapSnapshotGenerator::GenerateSnapshot() Line 2537	C++
 	node.dll!v8::internal::HeapProfiler::TakeSnapshot(v8::ActivityControl * control, v8::HeapProfiler::ObjectNameResolver * resolver) Line 84	C++
 	electron.exe!mate::internal::Invoker<mate::internal::IndicesHolder<0>,v8::Isolate * __ptr64>::DispatchToCallback(base::Callback<void __cdecl(v8::Isolate *),1,1> callback) Line 202	C++
 	electron.exe!mate::internal::Dispatcher<void __cdecl(v8::Isolate * __ptr64)>::DispatchToCallback(const v8::FunctionCallbackInfo<v8::Value> & info) Line 236	C++
 	node.dll!v8::internal::FunctionCallbackArguments::Call(void(*)(const v8::FunctionCallbackInfo<v8::Value> &) f) Line 26	C++
 	node.dll!v8::internal::`anonymous namespace'::HandleApiCallHelper<0>(v8::internal::Isolate * isolate, v8::internal::Handle<v8::internal::HeapObject> function, v8::internal::Handle<v8::internal::HeapObject> new_target, v8::internal::Handle<v8::internal::FunctionTemplateInfo> fun_data, v8::internal::Handle<v8::internal::Object> receiver, v8::internal::BuiltinArguments args) Line 113	C++
 	node.dll!v8::internal::Builtin_Impl_HandleApiCall(v8::internal::BuiltinArguments args, v8::internal::Isolate * isolate) Line 140	C++
 	node.dll!v8::internal::Builtin_HandleApiCall(int args_length, v8::internal::Object * * args_object, v8::internal::Isolate * isolate) Line 128	C++
 	[External Code]	
 	node.dll!v8::internal::Runtime_LoadIC_Miss(int args_length, v8::internal::Object * * args_object, v8::internal::Isolate * isolate) Line 2544	C++
 	[External Code]

It seems that some native classes were allocated in Chromium but freed in Node.

kevinsawicki · 2017-05-09T22:58:13Z

I have pushed a fix for the crash in the main process

Awesome work @zcbenz, specs no longer crash for me on Windows release builds, I've merged electron/libchromiumcontent#289

A new 58 release came out today and I've queued up the builds in electron/libchromiumcontent#290, I'll merge that into this branch once it completes.

kevinsawicki · 2017-05-10T21:40:26Z

This has been released to beta in 1.7.0, please open new issues for any bugs you hit.

zcbenz force-pushed the chrome58 branch from d6a4a53 to a1a7c69 Compare April 11, 2017 06:25

kevinsawicki mentioned this pull request Apr 12, 2017

Enable per-monitor DPI for Win10 #8786

Merged

zcbenz force-pushed the chrome58 branch 4 times, most recently from f83b19c to 9a19e2b Compare April 20, 2017 08:52

bbondy reviewed Apr 24, 2017

View reviewed changes

zcbenz added 23 commits April 27, 2017 16:34

Upgrade to Chrome 58.0.3029.40

453cb2c

Fix API changes of Chrome58

fc2d62d

Fix API changes in OSR code

9d1b88e

Fix API changes of base::Value

50e3bfa

Fix more API changes due to name changes

6be10ff

Update libcc to fix missing gen/cc headers

803120d

ResourceHandler API has been changed

5fb87f0

IsolateHolder API has been changed

dd3d791

Add gen/third_party/WebKit to include dirs

8634f37

Fix blink API changes

481b043

Use blink::SchemeRegistry over WebSecurityPolicy

e43b34b

The latter is removing some APIs we use.

Update Singleton code

9f94a0b

Fix change of FileDescriptorWatcher API

326908c

Update printing code

6da696b

Fix API changes of FrameSubscriber

d85b58f

Fix crash on exit

b2b2d8d

Don't use gzip when uploading crash reports

08069e1

Fix lack of some Chromium headers

7d9d82b

There are a few more new values for ChangeCause

97fd383

Fix building on Linux

b3d60bf

Fix symbol conflicts in Xlib.h

8c5fd76

Fix building on Windows

fb42a72

Fix crash when using secure schemes

0fb746b

zcbenz added 4 commits April 27, 2017 16:34

Fix unresolved symbol to icu::DateInterval

620a1ca

Fix release build

cbd3b05

Fix typo when updating code

301ed2d

Update to Node v7.9.0

4c47f2d

zcbenz force-pushed the chrome58 branch from 900d6ea to 4c47f2d Compare April 27, 2017 08:20

Update to Chrome 58.0.3029.81

dd2d0b3

kevinsawicki added 2 commits May 2, 2017 09:15

Merge remote-tracking branch 'origin/master' into chrome58

c6c9321

Build spec modules against locally generated node headers tarball

c19c14d

kevinsawicki added 2 commits May 2, 2017 13:24

Rebuild native modules during bootstrap

20fa2ce

Use nodedir option to specify local headers

164b97a

kevinsawicki force-pushed the chrome58 branch from 4604ca5 to 164b97a Compare May 2, 2017 21:37

Upgrade to Chrome 58.0.3029.96

e1d564d

kevinsawicki and others added 3 commits May 8, 2017 13:43

🎨

3dee76a

coffee -> js

8be4332

zcbenz mentioned this pull request May 9, 2017

Stop using experimental allocator shim on win32 electron/libchromiumcontent#289

Merged

kevinsawicki added 3 commits May 9, 2017 21:14

Upgrade to Chrome 58.0.3029.110

65bd0ec

Merge remote-tracking branch 'origin/master' into chrome58

fb85b26

Update NotifyObserversCertDBChanged call to take no arguments

de38461

kevinsawicki merged commit 7d3b58a into master May 10, 2017

kevinsawicki deleted the chrome58 branch May 10, 2017 17:41

kevinsawicki mentioned this pull request May 25, 2017

Rebuild native modules before specs run #9589

Merged

albinekb mentioned this pull request Jun 2, 2017

🌹 Update travis node vercel/hyper#1900

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to Chrome 58#9116

Upgrade to Chrome 58#9116
kevinsawicki merged 41 commits intomasterfrom
chrome58

zcbenz commented Apr 5, 2017 •

edited by kevinsawicki

Loading

Uh oh!

bbondy Apr 24, 2017

Uh oh!

zcbenz Apr 24, 2017

Uh oh!

zcbenz commented Apr 27, 2017

Uh oh!

kevinsawicki commented May 2, 2017 •

edited

Loading

Uh oh!

kevinsawicki commented May 3, 2017 •

edited

Loading

Uh oh!

kevinsawicki commented May 8, 2017 •

edited

Loading

Uh oh!

zcbenz commented May 9, 2017

Uh oh!

kevinsawicki commented May 9, 2017

Uh oh!

kevinsawicki commented May 10, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

zcbenz commented Apr 5, 2017 • edited by kevinsawicki Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bbondy Apr 24, 2017

Choose a reason for hiding this comment

Uh oh!

zcbenz Apr 24, 2017

Choose a reason for hiding this comment

Uh oh!

zcbenz commented Apr 27, 2017

Uh oh!

kevinsawicki commented May 2, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kevinsawicki commented May 3, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kevinsawicki commented May 8, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zcbenz commented May 9, 2017

Uh oh!

kevinsawicki commented May 9, 2017

Uh oh!

kevinsawicki commented May 10, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

zcbenz commented Apr 5, 2017 •

edited by kevinsawicki

Loading

kevinsawicki commented May 2, 2017 •

edited

Loading

kevinsawicki commented May 3, 2017 •

edited

Loading

kevinsawicki commented May 8, 2017 •

edited

Loading