Skip to content

Add showHiddenFiles property for dialog.showOpenDialog#6431

Merged
zcbenz merged 4 commits into
masterfrom
show-hidden-files
Jul 11, 2016
Merged

Add showHiddenFiles property for dialog.showOpenDialog#6431
zcbenz merged 4 commits into
masterfrom
show-hidden-files

Conversation

@zcbenz

@zcbenz zcbenz commented Jul 11, 2016

Copy link
Copy Markdown
Contributor

Close #3262.

@zcbenz zcbenz merged commit d5a7b3b into master Jul 11, 2016
@zcbenz zcbenz deleted the show-hidden-files branch July 11, 2016 05:58
@bpasero

bpasero commented Aug 31, 2016

Copy link
Copy Markdown
Contributor

@zcbenz I am trying to use this property via Electron 1.3.4 and in none of the OS I run (Windows 10, Mac OS X 10.11.6, Ubuntu 15) I am seeing an option in the dialog to show hidden files.

I am using the following properties:

  • Mac: 'multiSelections', 'openDirectory', 'openFile', 'createDirectory', 'showHiddenFiles'
  • Windows/Linux: 'multiSelections', 'openFile', 'createDirectory', 'showHiddenFiles'

@zcbenz

zcbenz commented Aug 31, 2016

Copy link
Copy Markdown
Contributor Author

@bpasero This option just forces the dialog to show all hidden files, adding a toggle in the dialog would involve much more work than this, since it requires custom view.

@bpasero

bpasero commented Aug 31, 2016

Copy link
Copy Markdown
Contributor

@zcbenz ok got it, I was just looking at the screenshot in #3262 (comment) and was hunting for that toggle, but the way it works now is also perfectly fine 👍

imlucas added a commit to mongodb-js/compass that referenced this pull request Sep 10, 2016
…nel identity file path

Using the
[`showHiddenFiles`](electron/electron#6431)
dialog option added in electron@1.2.7
kangas pushed a commit to mongodb-js/compass that referenced this pull request Sep 10, 2016
…nel identity file path (#470)

Using the
[`showHiddenFiles`](electron/electron#6431)
dialog option added in electron@1.2.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants