chore: bump chromium to 150.0.7863.0 (main)#51794
Merged
Merged
Conversation
Upstream relocated the closing brace of the `if (!ca_context_)` block to after `#endif // !BUILDFLAG(IS_IOS) || BUILDFLAG(IS_IOS_TVOS)`. Repositioned the MAS `#endif` accordingly so the IS_MAS_BUILD guard still wraps the entire function body. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7872896 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Signed-off-by: John Kleinschmidt <kleinschmidtorama@gmail.com>
Upstream renamed vector_icons::kCloseIcon to kCloseSmallIcon. Updated the Google-branded icon fallback in the PiP close button patch accordingly. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7876807 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Signed-off-by: John Kleinschmidt <kleinschmidtorama@gmail.com>
Upstream moved the use_thin_lto declaration to an earlier declare_args() block and folded is_mac + (is_ios && use_lld) into a single is_apple condition. Re-targeted the patch at the new location and replaced is_apple with is_ios so thin LTO remains disabled on macOS while staying enabled for iOS. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7839163 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Signed-off-by: John Kleinschmidt <kleinschmidtorama@gmail.com>
…tTextMethod Upstream renamed FitText -> TextFit (and ConvertFitText -> ConvertTextFit). Updated the corner-smoothing patch's surrounding declarations and definitions to match the new name, keeping the inserted ConvertCornerSmoothing entry just before ConvertTextFit. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7867233 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Signed-off-by: John Kleinschmidt <kleinschmidtorama@gmail.com>
…nstexpr Upstream made ui::DomKey's integer constructor explicit, so the implicit conversion from uint32_t no longer works. Cast WebKeyboardEvent::dom_key to ui::DomKey explicitly before calling DomKeyToKeyString. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7777607 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Signed-off-by: John Kleinschmidt <kleinschmidtorama@gmail.com>
Upstream removed the SCREAMING_ENUM_STYLE aliases on extensions::Manifest::Type. Switched from TYPE_EXTENSION to Type::kExtension. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7872317 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Signed-off-by: John Kleinschmidt <kleinschmidtorama@gmail.com>
Member
|
Green build here: https://github.com/electron/electron/actions/runs/26602250238 |
351e807 to
677c970
Compare
dsanders11
approved these changes
May 29, 2026
ckerr
approved these changes
May 29, 2026
|
Release Notes Persisted
|
Member
|
/trop run backport-to 43-x-y |
Contributor
|
The backport process for this PR has been manually initiated - sending your PR to |
Contributor
|
I was unable to backport this PR to "43-x-y" cleanly; |
jkleinsc
pushed a commit
that referenced
this pull request
May 29, 2026
Skip-Lint: cherry pick of #51794 * chore: bump chromium in DEPS to 150.0.7863.0 * 7872896: [iOS Blink] Fix build breaks in ca_layer_tree_coordinator.mm Upstream relocated the closing brace of the `if (!ca_context_)` block to after `#endif // !BUILDFLAG(IS_IOS) || BUILDFLAG(IS_IOS_TVOS)`. Repositioned the MAS `#endif` accordingly so the IS_MAS_BUILD guard still wraps the entire function body. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7872896 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Signed-off-by: John Kleinschmidt <kleinschmidtorama@gmail.com> * 7876807: [GlowUp] Adjust icons Upstream renamed vector_icons::kCloseIcon to kCloseSmallIcon. Updated the Google-branded icon fallback in the PiP close button patch accordingly. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7876807 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Signed-off-by: John Kleinschmidt <kleinschmidtorama@gmail.com> * 7839163: Reland "Roll out Apple Linker for macOS non-official builds" Upstream moved the use_thin_lto declaration to an earlier declare_args() block and folded is_mac + (is_ios && use_lld) into a single is_apple condition. Re-targeted the patch at the new location and replaced is_apple with is_ios so thin LTO remains disabled on macOS while staying enabled for iOS. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7839163 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Signed-off-by: John Kleinschmidt <kleinschmidtorama@gmail.com> * 7867233: text-fit: Rename FitText, FitTextType, FitTextTarget, and FitTextMethod Upstream renamed FitText -> TextFit (and ConvertFitText -> ConvertTextFit). Updated the corner-smoothing patch's surrounding declarations and definitions to match the new name, keeping the inserted ConvertCornerSmoothing entry just before ConvertTextFit. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7867233 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Signed-off-by: John Kleinschmidt <kleinschmidtorama@gmail.com> * chore: update patches * 7777607: Replace ui::DomKey implicit constructor with C++17 inline constexpr Upstream made ui::DomKey's integer constructor explicit, so the implicit conversion from uint32_t no longer works. Cast WebKeyboardEvent::dom_key to ui::DomKey explicitly before calling DomKeyToKeyString. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7777607 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Signed-off-by: John Kleinschmidt <kleinschmidtorama@gmail.com> * 7872317: [Extensions] Remove duplicate type entries from Manifest::Type Upstream removed the SCREAMING_ENUM_STYLE aliases on extensions::Manifest::Type. Switched from TYPE_EXTENSION to Type::kExtension. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7872317 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Signed-off-by: John Kleinschmidt <kleinschmidtorama@gmail.com> --------- Signed-off-by: John Kleinschmidt <kleinschmidtorama@gmail.com> Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: chromium-roller[bot] <chromium-roller[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
ckerr
pushed a commit
that referenced
this pull request
May 31, 2026
* chore: bump chromium in DEPS to 150.0.7865.1 * chore: bump chromium to 150.0.7863.0 (main) (#51794) Skip-Lint: cherry pick of #51794 * chore: bump chromium in DEPS to 150.0.7863.0 * 7872896: [iOS Blink] Fix build breaks in ca_layer_tree_coordinator.mm Upstream relocated the closing brace of the `if (!ca_context_)` block to after `#endif // !BUILDFLAG(IS_IOS) || BUILDFLAG(IS_IOS_TVOS)`. Repositioned the MAS `#endif` accordingly so the IS_MAS_BUILD guard still wraps the entire function body. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7872896 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Signed-off-by: John Kleinschmidt <kleinschmidtorama@gmail.com> * 7876807: [GlowUp] Adjust icons Upstream renamed vector_icons::kCloseIcon to kCloseSmallIcon. Updated the Google-branded icon fallback in the PiP close button patch accordingly. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7876807 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Signed-off-by: John Kleinschmidt <kleinschmidtorama@gmail.com> * 7839163: Reland "Roll out Apple Linker for macOS non-official builds" Upstream moved the use_thin_lto declaration to an earlier declare_args() block and folded is_mac + (is_ios && use_lld) into a single is_apple condition. Re-targeted the patch at the new location and replaced is_apple with is_ios so thin LTO remains disabled on macOS while staying enabled for iOS. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7839163 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Signed-off-by: John Kleinschmidt <kleinschmidtorama@gmail.com> * 7867233: text-fit: Rename FitText, FitTextType, FitTextTarget, and FitTextMethod Upstream renamed FitText -> TextFit (and ConvertFitText -> ConvertTextFit). Updated the corner-smoothing patch's surrounding declarations and definitions to match the new name, keeping the inserted ConvertCornerSmoothing entry just before ConvertTextFit. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7867233 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Signed-off-by: John Kleinschmidt <kleinschmidtorama@gmail.com> * chore: update patches * 7777607: Replace ui::DomKey implicit constructor with C++17 inline constexpr Upstream made ui::DomKey's integer constructor explicit, so the implicit conversion from uint32_t no longer works. Cast WebKeyboardEvent::dom_key to ui::DomKey explicitly before calling DomKeyToKeyString. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7777607 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Signed-off-by: John Kleinschmidt <kleinschmidtorama@gmail.com> * 7872317: [Extensions] Remove duplicate type entries from Manifest::Type Upstream removed the SCREAMING_ENUM_STYLE aliases on extensions::Manifest::Type. Switched from TYPE_EXTENSION to Type::kExtension. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7872317 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Signed-off-by: John Kleinschmidt <kleinschmidtorama@gmail.com> --------- Signed-off-by: John Kleinschmidt <kleinschmidtorama@gmail.com> Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: chromium-roller[bot] <chromium-roller[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com> --------- Signed-off-by: John Kleinschmidt <kleinschmidtorama@gmail.com> Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: chromium-roller[bot] <chromium-roller[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating Chromium to 150.0.7863.0.
See all changes in 150.0.7857.0..150.0.7863.0
Notes: Updated Chromium to 150.0.7863.0.