Skip to content

chore: bump chromium to 150.0.7844.0 (main)#51610

Merged
ckerr merged 24 commits into
mainfrom
roller/chromium/main
May 20, 2026
Merged

chore: bump chromium to 150.0.7844.0 (main)#51610
ckerr merged 24 commits into
mainfrom
roller/chromium/main

Conversation

@electron-roller

@electron-roller electron-roller Bot commented May 13, 2026

Copy link
Copy Markdown
Contributor

Updating Chromium to 150.0.7844.0.

See all changes in 150.0.7834.0..150.0.7844.0

Notes: Updated Chromium to 150.0.7844.0.

@electron-roller electron-roller Bot requested a review from a team as a code owner May 13, 2026 21:12
@electron-roller electron-roller Bot added no-backport semver/patch backwards-compatible bug fixes labels May 13, 2026
@electron-cation electron-cation Bot added the new-pr 🌱 PR opened recently label May 13, 2026
@electron-roller electron-roller Bot changed the title chore: bump chromium to 150.0.7839.0 (main) chore: bump chromium to 150.0.7840.0 (main) May 14, 2026
@jkleinsc jkleinsc added target/43-x-y PR should also be added to the "43-x-y" branch. and removed no-backport labels May 14, 2026
@electron-cation electron-cation Bot removed the new-pr 🌱 PR opened recently label May 14, 2026
@electron-roller electron-roller Bot changed the title chore: bump chromium to 150.0.7840.0 (main) chore: bump chromium to 150.0.7841.0 (main) May 15, 2026
VerteDinde and others added 2 commits May 14, 2026 20:26
… upgrade

The sqlite amalgamation was rolled to 3.53.1, which regenerated
rename_exports.h with new line numbers for all exports. Updated the patch
context to match the new file while preserving the win32 export renames.

Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7828672

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
@VerteDinde VerteDinde force-pushed the roller/chromium/main branch from 8832d1e to 22a0480 Compare May 15, 2026 04:14
@VerteDinde VerteDinde requested a review from a team as a code owner May 15, 2026 04:14
Upstream removed extensions/browser/media_capture_util.h/cc as dead code
after deleting app_shell. Electron still needs GrantMediaStreamRequest
and VerifyMediaAccessPermission, so inline the logic directly into
ElectronExtensionHostDelegate.

Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7836112
@VerteDinde VerteDinde requested a review from a team as a code owner May 15, 2026 21:29
@VerteDinde VerteDinde force-pushed the roller/chromium/main branch from 06a18bb to f344204 Compare May 15, 2026 21:33
@electron-roller electron-roller Bot changed the title chore: bump chromium to 150.0.7841.0 (main) chore: bump chromium to 150.0.7843.0 (main) May 16, 2026
@electron-roller electron-roller Bot changed the title chore: bump chromium to 150.0.7843.0 (main) chore: bump chromium to 150.0.7844.0 (main) May 18, 2026
Comment thread shell/browser/extensions/electron_extension_host_delegate.cc
Comment thread shell/browser/plugins/plugin_utils.h Outdated
Comment thread shell/browser/extensions/api/streams_private/streams_private_api.cc
Comment thread shell/browser/extensions/api/streams_private/streams_private_api.cc

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think more consideration on this patch being dropped is necessary. After the upstream change there's still os.Open, it's just pushed down a level into mmapfile.Read, so I think the same issue this patch addresses remains and we need to adjust the patch, not remove it.

…he to SendExecuteMimeTypeHandlerEvent

Upstream added an `embedded` parameter to PluginUtils::GetExtensionIdForMimeType
to honor MIME handler can_embed settings, and a `body_cache` parameter to
SendExecuteMimeTypeHandlerEvent for PDF fallback-to-native replay. Updated
Electron's implementations to accept the new parameters.

Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7801320
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7781210
VerteDinde and others added 6 commits May 18, 2026 17:39
Removed ctype.h, fenv.h, and inttypes.h which were deleted upstream.
Upstream rewrote file_parser.go's readFile to use mmapfile.Read instead
of os.Open + chunked ReadAt goroutines. The race condition in bindflt.sys
that these patches worked around (redundant CreateFileW calls under
concurrent opens) can no longer occur with the new mmap-based approach.

Also guard the git am step against an empty patches directory.
Upstream guarded the CAContext reallocation on resize behind the
kCATransactionV2 feature flag. Updated the MAS build guard to preserve
this new condition alongside the existing allow_remote_layers_ check.

Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7850052

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
@dsanders11 dsanders11 force-pushed the roller/chromium/main branch from 73aeea9 to 8461474 Compare May 19, 2026 01:03
@dsanders11 dsanders11 force-pushed the roller/chromium/main branch from 8461474 to 8970956 Compare May 19, 2026 02:25
@dsanders11 dsanders11 force-pushed the roller/chromium/main branch from 8970956 to 12ff2bc Compare May 19, 2026 02:41

@jkleinsc jkleinsc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node test failure is legitimate, probably caused by https://chromium-review.googlesource.com/c/v8/v8/+/7832184.

The codepath that produced the warning this Node.js test was
asserting on is no longer taken after the upstream change.

Refs https://chromium-review.googlesource.com/c/v8/v8/+/7832184

@jkleinsc jkleinsc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be inadvertent changes to typings/internal-ambient.d.ts due to the merge of main

@ckerr ckerr merged commit 23af5c4 into main May 20, 2026
124 of 126 checks passed
@ckerr ckerr deleted the roller/chromium/main branch May 20, 2026 15:54
@release-clerk

release-clerk Bot commented May 20, 2026

Copy link
Copy Markdown

Release Notes Persisted

Updated Chromium to 150.0.7844.0.

@trop

trop Bot commented May 20, 2026

Copy link
Copy Markdown
Contributor

I was unable to backport this PR to "43-x-y" cleanly;
you will need to perform this backport manually.

@trop trop Bot added needs-manual-bp/43-x-y and removed target/43-x-y PR should also be added to the "43-x-y" branch. labels May 20, 2026
jkleinsc pushed a commit that referenced this pull request May 26, 2026
* chore: bump chromium in DEPS to 150.0.7839.0

* chore: bump chromium in DEPS to 150.0.7840.0

* fix(patch-conflict): update sqlite rename_exports.h for sqlite 3.53.1 upgrade

The sqlite amalgamation was rolled to 3.53.1, which regenerated
rename_exports.h with new line numbers for all exports. Updated the patch
context to match the new file while preserving the win32 export renames.

Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7828672

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>

* chore: update patch hunk headers

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>

* 7836112: inline media_capture_util after upstream removal

Upstream removed extensions/browser/media_capture_util.h/cc as dead code
after deleting app_shell. Electron still needs GrantMediaStreamRequest
and VerifyMediaAccessPermission, so inline the logic directly into
ElectronExtensionHostDelegate.

Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7836112

* 7801320: add embedded param to GetExtensionIdForMimeType and body_cache to SendExecuteMimeTypeHandlerEvent

Upstream added an `embedded` parameter to PluginUtils::GetExtensionIdForMimeType
to honor MIME handler can_embed settings, and a `body_cache` parameter to
SendExecuteMimeTypeHandlerEvent for PDF fallback-to-native replay. Updated
Electron's implementations to accept the new parameters.

Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7801320
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7781210

* fix(patch-update): update kIcCloseIcon to kIcCloseOldIcon in picture-in-picture patch

Upstream renamed ui/views/vector_icons/ic_close.icon to ic_close_old.icon,
which changes the generated symbol from kIcCloseIcon to kIcCloseOldIcon.

Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7795717

* chore: bump chromium in DEPS to 150.0.7841.0

* fix(patch-conflict): update picture-in-picture patch for kCloseChromeRefresh icon rename

Upstream renamed kCloseChromeRefreshIcon to kCloseChromeRefreshOldIcon in
the same sweep that renamed kIcCloseIcon to kIcCloseOldIcon. Updated the
patch to reference kCloseChromeRefreshOldIcon in the GOOGLE_CHROME_BRANDING
guard.

Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7795717

* chore: update patch hunk headers

* 7795717: update window control icon names for upstream rename

Upstream renamed all views vector icons with an "Old" suffix as part of
the GlowUp icon refresh. Updated kWindowControlMinimizeIcon,
kWindowControlMaximizeIcon, kWindowControlRestoreIcon, and
kWindowControlCloseIcon to their *OldIcon variants.

Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7795717

* chore: regenerate filenames.libcxx.gni

Removed ctype.h, fenv.h, and inttypes.h which were deleted upstream.

* chore: remove obsolete siso patches

Upstream rewrote file_parser.go's readFile to use mmapfile.Read instead
of os.Open + chunked ReadAt goroutines. The race condition in bindflt.sys
that these patches worked around (redundant CreateFileW calls under
concurrent opens) can no longer occur with the new mmap-based approach.

Also guard the git am step against an empty patches directory.

* chore: bump chromium in DEPS to 150.0.7843.0

* chore: bump chromium in DEPS to 150.0.7844.0

* fix(patch-conflict): update mas patch for CATransactionV2 feature guard

Upstream guarded the CAContext reallocation on resize behind the
kCATransactionV2 feature flag. Updated the MAS build guard to preserve
this new condition alongside the existing allow_remote_layers_ check.

Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7850052

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>

* chore: update patch hunk headers

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>

* fixup! 7836112: inline media_capture_util after upstream removal

* fixup! chore: remove obsolete siso patches

* 7832184: [asm.js] Disable asm.js-to-Wasm translation

The codepath that produced the warning this Node.js test was
asserting on is no longer taken after the upstream change.

Refs https://chromium-review.googlesource.com/c/v8/v8/+/7832184

* chore: update patches

* chore: back out unrelated formatting changes

---------

(cherry picked from commit 23af5c4)

Skip-Lint: cherry-pick of #51610
jkleinsc pushed a commit that referenced this pull request May 27, 2026
* chore: bump chromium in DEPS to 150.0.7839.0

* chore: bump chromium in DEPS to 150.0.7840.0

* fix(patch-conflict): update sqlite rename_exports.h for sqlite 3.53.1 upgrade

The sqlite amalgamation was rolled to 3.53.1, which regenerated
rename_exports.h with new line numbers for all exports. Updated the patch
context to match the new file while preserving the win32 export renames.

Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7828672

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>

* chore: update patch hunk headers

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>

* 7836112: inline media_capture_util after upstream removal

Upstream removed extensions/browser/media_capture_util.h/cc as dead code
after deleting app_shell. Electron still needs GrantMediaStreamRequest
and VerifyMediaAccessPermission, so inline the logic directly into
ElectronExtensionHostDelegate.

Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7836112

* 7801320: add embedded param to GetExtensionIdForMimeType and body_cache to SendExecuteMimeTypeHandlerEvent

Upstream added an `embedded` parameter to PluginUtils::GetExtensionIdForMimeType
to honor MIME handler can_embed settings, and a `body_cache` parameter to
SendExecuteMimeTypeHandlerEvent for PDF fallback-to-native replay. Updated
Electron's implementations to accept the new parameters.

Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7801320
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7781210

* fix(patch-update): update kIcCloseIcon to kIcCloseOldIcon in picture-in-picture patch

Upstream renamed ui/views/vector_icons/ic_close.icon to ic_close_old.icon,
which changes the generated symbol from kIcCloseIcon to kIcCloseOldIcon.

Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7795717

* chore: bump chromium in DEPS to 150.0.7841.0

* fix(patch-conflict): update picture-in-picture patch for kCloseChromeRefresh icon rename

Upstream renamed kCloseChromeRefreshIcon to kCloseChromeRefreshOldIcon in
the same sweep that renamed kIcCloseIcon to kIcCloseOldIcon. Updated the
patch to reference kCloseChromeRefreshOldIcon in the GOOGLE_CHROME_BRANDING
guard.

Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7795717

* chore: update patch hunk headers

* 7795717: update window control icon names for upstream rename

Upstream renamed all views vector icons with an "Old" suffix as part of
the GlowUp icon refresh. Updated kWindowControlMinimizeIcon,
kWindowControlMaximizeIcon, kWindowControlRestoreIcon, and
kWindowControlCloseIcon to their *OldIcon variants.

Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7795717

* chore: regenerate filenames.libcxx.gni

Removed ctype.h, fenv.h, and inttypes.h which were deleted upstream.

* chore: remove obsolete siso patches

Upstream rewrote file_parser.go's readFile to use mmapfile.Read instead
of os.Open + chunked ReadAt goroutines. The race condition in bindflt.sys
that these patches worked around (redundant CreateFileW calls under
concurrent opens) can no longer occur with the new mmap-based approach.

Also guard the git am step against an empty patches directory.

* chore: bump chromium in DEPS to 150.0.7843.0

* chore: bump chromium in DEPS to 150.0.7844.0

* fix(patch-conflict): update mas patch for CATransactionV2 feature guard

Upstream guarded the CAContext reallocation on resize behind the
kCATransactionV2 feature flag. Updated the MAS build guard to preserve
this new condition alongside the existing allow_remote_layers_ check.

Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7850052

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>

* chore: update patch hunk headers

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>

* fixup! 7836112: inline media_capture_util after upstream removal

* fixup! chore: remove obsolete siso patches

* 7832184: [asm.js] Disable asm.js-to-Wasm translation

The codepath that produced the warning this Node.js test was
asserting on is no longer taken after the upstream change.

Refs https://chromium-review.googlesource.com/c/v8/v8/+/7832184

* chore: update patches

* chore: back out unrelated formatting changes

---------

(cherry picked from commit 23af5c4)

Skip-Lint: cherry-pick of #51610
ckerr pushed a commit that referenced this pull request May 28, 2026
* chore: bump chromium in DEPS to 150.0.7841.1

* chore: bump chromium in DEPS to 150.0.7841.2

* chore: bump chromium in DEPS to 150.0.7843.1

* chore: bump chromium in DEPS to 150.0.7843.3

* chore: bump chromium in DEPS to 150.0.7844.0

* chore: bump chromium in DEPS to 150.0.7846.1

* chore: bump chromium in DEPS to 150.0.7847.1

* chore: bump chromium in DEPS to 150.0.7849.1

* chore: bump chromium in DEPS to 150.0.7846.4

* chore: bump chromium in DEPS to 150.0.7851.1

* chore: bump chromium in DEPS to 150.0.7853.1

* chore: bump chromium in DEPS to 150.0.7855.1

* chore: bump chromium in DEPS to 150.0.7857.1

* chore: bump chromium in DEPS to 150.0.7859.1

* chore: bump chromium to 150.0.7844.0 (main) (#51610)

* chore: bump chromium in DEPS to 150.0.7839.0

* chore: bump chromium in DEPS to 150.0.7840.0

* fix(patch-conflict): update sqlite rename_exports.h for sqlite 3.53.1 upgrade

The sqlite amalgamation was rolled to 3.53.1, which regenerated
rename_exports.h with new line numbers for all exports. Updated the patch
context to match the new file while preserving the win32 export renames.

Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7828672

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>

* chore: update patch hunk headers

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>

* 7836112: inline media_capture_util after upstream removal

Upstream removed extensions/browser/media_capture_util.h/cc as dead code
after deleting app_shell. Electron still needs GrantMediaStreamRequest
and VerifyMediaAccessPermission, so inline the logic directly into
ElectronExtensionHostDelegate.

Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7836112

* 7801320: add embedded param to GetExtensionIdForMimeType and body_cache to SendExecuteMimeTypeHandlerEvent

Upstream added an `embedded` parameter to PluginUtils::GetExtensionIdForMimeType
to honor MIME handler can_embed settings, and a `body_cache` parameter to
SendExecuteMimeTypeHandlerEvent for PDF fallback-to-native replay. Updated
Electron's implementations to accept the new parameters.

Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7801320
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7781210

* fix(patch-update): update kIcCloseIcon to kIcCloseOldIcon in picture-in-picture patch

Upstream renamed ui/views/vector_icons/ic_close.icon to ic_close_old.icon,
which changes the generated symbol from kIcCloseIcon to kIcCloseOldIcon.

Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7795717

* chore: bump chromium in DEPS to 150.0.7841.0

* fix(patch-conflict): update picture-in-picture patch for kCloseChromeRefresh icon rename

Upstream renamed kCloseChromeRefreshIcon to kCloseChromeRefreshOldIcon in
the same sweep that renamed kIcCloseIcon to kIcCloseOldIcon. Updated the
patch to reference kCloseChromeRefreshOldIcon in the GOOGLE_CHROME_BRANDING
guard.

Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7795717

* chore: update patch hunk headers

* 7795717: update window control icon names for upstream rename

Upstream renamed all views vector icons with an "Old" suffix as part of
the GlowUp icon refresh. Updated kWindowControlMinimizeIcon,
kWindowControlMaximizeIcon, kWindowControlRestoreIcon, and
kWindowControlCloseIcon to their *OldIcon variants.

Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7795717

* chore: regenerate filenames.libcxx.gni

Removed ctype.h, fenv.h, and inttypes.h which were deleted upstream.

* chore: remove obsolete siso patches

Upstream rewrote file_parser.go's readFile to use mmapfile.Read instead
of os.Open + chunked ReadAt goroutines. The race condition in bindflt.sys
that these patches worked around (redundant CreateFileW calls under
concurrent opens) can no longer occur with the new mmap-based approach.

Also guard the git am step against an empty patches directory.

* chore: bump chromium in DEPS to 150.0.7843.0

* chore: bump chromium in DEPS to 150.0.7844.0

* fix(patch-conflict): update mas patch for CATransactionV2 feature guard

Upstream guarded the CAContext reallocation on resize behind the
kCATransactionV2 feature flag. Updated the MAS build guard to preserve
this new condition alongside the existing allow_remote_layers_ check.

Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7850052

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>

* chore: update patch hunk headers

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>

* fixup! 7836112: inline media_capture_util after upstream removal

* fixup! chore: remove obsolete siso patches

* 7832184: [asm.js] Disable asm.js-to-Wasm translation

The codepath that produced the warning this Node.js test was
asserting on is no longer taken after the upstream change.

Refs https://chromium-review.googlesource.com/c/v8/v8/+/7832184

* chore: update patches

* chore: back out unrelated formatting changes

---------

(cherry picked from commit 23af5c4)

Skip-Lint: cherry-pick of #51610

* chore: bump chromium to 150.0.7847.0 (main) (#51720)

* chore: bump chromium in DEPS to 150.0.7847.0

* chore: update patches

* 7845702: Speculative fix for pdf summarize button on ChromeOS.

Refs https://chromium-review.googlesource.com/c/chromium/src/+/7845702

---------

(cherry picked from commit 58322f7)

Skip-Lint: cherry-picked from #51720

* chore: bump chromium to 150.0.7849.0 (main) (#51733)

* chore: bump chromium in DEPS to 150.0.7849.0

* chore: update patches

* 7850982: [MenuSimplification] Plumb UsesNativeSystemMenu through Views HWND APIs

Refs https://chromium-review.googlesource.com/c/chromium/src/+/7850982

* 7789842: views: Add Windows-only support for excluding Widgets from screen capture

Refs https://chromium-review.googlesource.com/c/chromium/src/+/7789842

Assisted-by: Claude Opus 4.7

---------

(cherry picked from commit 9b0fb5b)

Skip-Lint: cherry picked from #51733

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants