chore: bump chromium to 150.0.7844.0 (main)#51610
Conversation
… upgrade The sqlite amalgamation was rolled to 3.53.1, which regenerated rename_exports.h with new line numbers for all exports. Updated the patch context to match the new file while preserving the win32 export renames. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7828672 Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
8832d1e to
22a0480
Compare
Upstream removed extensions/browser/media_capture_util.h/cc as dead code after deleting app_shell. Electron still needs GrantMediaStreamRequest and VerifyMediaAccessPermission, so inline the logic directly into ElectronExtensionHostDelegate. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7836112
06a18bb to
f344204
Compare
There was a problem hiding this comment.
I think more consideration on this patch being dropped is necessary. After the upstream change there's still os.Open, it's just pushed down a level into mmapfile.Read, so I think the same issue this patch addresses remains and we need to adjust the patch, not remove it.
…he to SendExecuteMimeTypeHandlerEvent Upstream added an `embedded` parameter to PluginUtils::GetExtensionIdForMimeType to honor MIME handler can_embed settings, and a `body_cache` parameter to SendExecuteMimeTypeHandlerEvent for PDF fallback-to-native replay. Updated Electron's implementations to accept the new parameters. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7801320 Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7781210
Removed ctype.h, fenv.h, and inttypes.h which were deleted upstream.
Upstream rewrote file_parser.go's readFile to use mmapfile.Read instead of os.Open + chunked ReadAt goroutines. The race condition in bindflt.sys that these patches worked around (redundant CreateFileW calls under concurrent opens) can no longer occur with the new mmap-based approach. Also guard the git am step against an empty patches directory.
Upstream guarded the CAContext reallocation on resize behind the kCATransactionV2 feature flag. Updated the MAS build guard to preserve this new condition alongside the existing allow_remote_layers_ check. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7850052 Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
73aeea9 to
8461474
Compare
8461474 to
8970956
Compare
8970956 to
12ff2bc
Compare
jkleinsc
left a comment
There was a problem hiding this comment.
Node test failure is legitimate, probably caused by https://chromium-review.googlesource.com/c/v8/v8/+/7832184.
The codepath that produced the warning this Node.js test was asserting on is no longer taken after the upstream change. Refs https://chromium-review.googlesource.com/c/v8/v8/+/7832184
jkleinsc
left a comment
There was a problem hiding this comment.
There seems to be inadvertent changes to typings/internal-ambient.d.ts due to the merge of main
|
Release Notes Persisted
|
|
I was unable to backport this PR to "43-x-y" cleanly; |
* chore: bump chromium in DEPS to 150.0.7839.0 * chore: bump chromium in DEPS to 150.0.7840.0 * fix(patch-conflict): update sqlite rename_exports.h for sqlite 3.53.1 upgrade The sqlite amalgamation was rolled to 3.53.1, which regenerated rename_exports.h with new line numbers for all exports. Updated the patch context to match the new file while preserving the win32 export renames. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7828672 Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> * chore: update patch hunk headers Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> * 7836112: inline media_capture_util after upstream removal Upstream removed extensions/browser/media_capture_util.h/cc as dead code after deleting app_shell. Electron still needs GrantMediaStreamRequest and VerifyMediaAccessPermission, so inline the logic directly into ElectronExtensionHostDelegate. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7836112 * 7801320: add embedded param to GetExtensionIdForMimeType and body_cache to SendExecuteMimeTypeHandlerEvent Upstream added an `embedded` parameter to PluginUtils::GetExtensionIdForMimeType to honor MIME handler can_embed settings, and a `body_cache` parameter to SendExecuteMimeTypeHandlerEvent for PDF fallback-to-native replay. Updated Electron's implementations to accept the new parameters. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7801320 Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7781210 * fix(patch-update): update kIcCloseIcon to kIcCloseOldIcon in picture-in-picture patch Upstream renamed ui/views/vector_icons/ic_close.icon to ic_close_old.icon, which changes the generated symbol from kIcCloseIcon to kIcCloseOldIcon. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7795717 * chore: bump chromium in DEPS to 150.0.7841.0 * fix(patch-conflict): update picture-in-picture patch for kCloseChromeRefresh icon rename Upstream renamed kCloseChromeRefreshIcon to kCloseChromeRefreshOldIcon in the same sweep that renamed kIcCloseIcon to kIcCloseOldIcon. Updated the patch to reference kCloseChromeRefreshOldIcon in the GOOGLE_CHROME_BRANDING guard. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7795717 * chore: update patch hunk headers * 7795717: update window control icon names for upstream rename Upstream renamed all views vector icons with an "Old" suffix as part of the GlowUp icon refresh. Updated kWindowControlMinimizeIcon, kWindowControlMaximizeIcon, kWindowControlRestoreIcon, and kWindowControlCloseIcon to their *OldIcon variants. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7795717 * chore: regenerate filenames.libcxx.gni Removed ctype.h, fenv.h, and inttypes.h which were deleted upstream. * chore: remove obsolete siso patches Upstream rewrote file_parser.go's readFile to use mmapfile.Read instead of os.Open + chunked ReadAt goroutines. The race condition in bindflt.sys that these patches worked around (redundant CreateFileW calls under concurrent opens) can no longer occur with the new mmap-based approach. Also guard the git am step against an empty patches directory. * chore: bump chromium in DEPS to 150.0.7843.0 * chore: bump chromium in DEPS to 150.0.7844.0 * fix(patch-conflict): update mas patch for CATransactionV2 feature guard Upstream guarded the CAContext reallocation on resize behind the kCATransactionV2 feature flag. Updated the MAS build guard to preserve this new condition alongside the existing allow_remote_layers_ check. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7850052 Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> * chore: update patch hunk headers Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> * fixup! 7836112: inline media_capture_util after upstream removal * fixup! chore: remove obsolete siso patches * 7832184: [asm.js] Disable asm.js-to-Wasm translation The codepath that produced the warning this Node.js test was asserting on is no longer taken after the upstream change. Refs https://chromium-review.googlesource.com/c/v8/v8/+/7832184 * chore: update patches * chore: back out unrelated formatting changes --------- (cherry picked from commit 23af5c4) Skip-Lint: cherry-pick of #51610
* chore: bump chromium in DEPS to 150.0.7839.0 * chore: bump chromium in DEPS to 150.0.7840.0 * fix(patch-conflict): update sqlite rename_exports.h for sqlite 3.53.1 upgrade The sqlite amalgamation was rolled to 3.53.1, which regenerated rename_exports.h with new line numbers for all exports. Updated the patch context to match the new file while preserving the win32 export renames. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7828672 Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> * chore: update patch hunk headers Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> * 7836112: inline media_capture_util after upstream removal Upstream removed extensions/browser/media_capture_util.h/cc as dead code after deleting app_shell. Electron still needs GrantMediaStreamRequest and VerifyMediaAccessPermission, so inline the logic directly into ElectronExtensionHostDelegate. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7836112 * 7801320: add embedded param to GetExtensionIdForMimeType and body_cache to SendExecuteMimeTypeHandlerEvent Upstream added an `embedded` parameter to PluginUtils::GetExtensionIdForMimeType to honor MIME handler can_embed settings, and a `body_cache` parameter to SendExecuteMimeTypeHandlerEvent for PDF fallback-to-native replay. Updated Electron's implementations to accept the new parameters. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7801320 Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7781210 * fix(patch-update): update kIcCloseIcon to kIcCloseOldIcon in picture-in-picture patch Upstream renamed ui/views/vector_icons/ic_close.icon to ic_close_old.icon, which changes the generated symbol from kIcCloseIcon to kIcCloseOldIcon. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7795717 * chore: bump chromium in DEPS to 150.0.7841.0 * fix(patch-conflict): update picture-in-picture patch for kCloseChromeRefresh icon rename Upstream renamed kCloseChromeRefreshIcon to kCloseChromeRefreshOldIcon in the same sweep that renamed kIcCloseIcon to kIcCloseOldIcon. Updated the patch to reference kCloseChromeRefreshOldIcon in the GOOGLE_CHROME_BRANDING guard. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7795717 * chore: update patch hunk headers * 7795717: update window control icon names for upstream rename Upstream renamed all views vector icons with an "Old" suffix as part of the GlowUp icon refresh. Updated kWindowControlMinimizeIcon, kWindowControlMaximizeIcon, kWindowControlRestoreIcon, and kWindowControlCloseIcon to their *OldIcon variants. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7795717 * chore: regenerate filenames.libcxx.gni Removed ctype.h, fenv.h, and inttypes.h which were deleted upstream. * chore: remove obsolete siso patches Upstream rewrote file_parser.go's readFile to use mmapfile.Read instead of os.Open + chunked ReadAt goroutines. The race condition in bindflt.sys that these patches worked around (redundant CreateFileW calls under concurrent opens) can no longer occur with the new mmap-based approach. Also guard the git am step against an empty patches directory. * chore: bump chromium in DEPS to 150.0.7843.0 * chore: bump chromium in DEPS to 150.0.7844.0 * fix(patch-conflict): update mas patch for CATransactionV2 feature guard Upstream guarded the CAContext reallocation on resize behind the kCATransactionV2 feature flag. Updated the MAS build guard to preserve this new condition alongside the existing allow_remote_layers_ check. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7850052 Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> * chore: update patch hunk headers Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> * fixup! 7836112: inline media_capture_util after upstream removal * fixup! chore: remove obsolete siso patches * 7832184: [asm.js] Disable asm.js-to-Wasm translation The codepath that produced the warning this Node.js test was asserting on is no longer taken after the upstream change. Refs https://chromium-review.googlesource.com/c/v8/v8/+/7832184 * chore: update patches * chore: back out unrelated formatting changes --------- (cherry picked from commit 23af5c4) Skip-Lint: cherry-pick of #51610
* chore: bump chromium in DEPS to 150.0.7841.1 * chore: bump chromium in DEPS to 150.0.7841.2 * chore: bump chromium in DEPS to 150.0.7843.1 * chore: bump chromium in DEPS to 150.0.7843.3 * chore: bump chromium in DEPS to 150.0.7844.0 * chore: bump chromium in DEPS to 150.0.7846.1 * chore: bump chromium in DEPS to 150.0.7847.1 * chore: bump chromium in DEPS to 150.0.7849.1 * chore: bump chromium in DEPS to 150.0.7846.4 * chore: bump chromium in DEPS to 150.0.7851.1 * chore: bump chromium in DEPS to 150.0.7853.1 * chore: bump chromium in DEPS to 150.0.7855.1 * chore: bump chromium in DEPS to 150.0.7857.1 * chore: bump chromium in DEPS to 150.0.7859.1 * chore: bump chromium to 150.0.7844.0 (main) (#51610) * chore: bump chromium in DEPS to 150.0.7839.0 * chore: bump chromium in DEPS to 150.0.7840.0 * fix(patch-conflict): update sqlite rename_exports.h for sqlite 3.53.1 upgrade The sqlite amalgamation was rolled to 3.53.1, which regenerated rename_exports.h with new line numbers for all exports. Updated the patch context to match the new file while preserving the win32 export renames. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7828672 Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> * chore: update patch hunk headers Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> * 7836112: inline media_capture_util after upstream removal Upstream removed extensions/browser/media_capture_util.h/cc as dead code after deleting app_shell. Electron still needs GrantMediaStreamRequest and VerifyMediaAccessPermission, so inline the logic directly into ElectronExtensionHostDelegate. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7836112 * 7801320: add embedded param to GetExtensionIdForMimeType and body_cache to SendExecuteMimeTypeHandlerEvent Upstream added an `embedded` parameter to PluginUtils::GetExtensionIdForMimeType to honor MIME handler can_embed settings, and a `body_cache` parameter to SendExecuteMimeTypeHandlerEvent for PDF fallback-to-native replay. Updated Electron's implementations to accept the new parameters. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7801320 Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7781210 * fix(patch-update): update kIcCloseIcon to kIcCloseOldIcon in picture-in-picture patch Upstream renamed ui/views/vector_icons/ic_close.icon to ic_close_old.icon, which changes the generated symbol from kIcCloseIcon to kIcCloseOldIcon. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7795717 * chore: bump chromium in DEPS to 150.0.7841.0 * fix(patch-conflict): update picture-in-picture patch for kCloseChromeRefresh icon rename Upstream renamed kCloseChromeRefreshIcon to kCloseChromeRefreshOldIcon in the same sweep that renamed kIcCloseIcon to kIcCloseOldIcon. Updated the patch to reference kCloseChromeRefreshOldIcon in the GOOGLE_CHROME_BRANDING guard. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7795717 * chore: update patch hunk headers * 7795717: update window control icon names for upstream rename Upstream renamed all views vector icons with an "Old" suffix as part of the GlowUp icon refresh. Updated kWindowControlMinimizeIcon, kWindowControlMaximizeIcon, kWindowControlRestoreIcon, and kWindowControlCloseIcon to their *OldIcon variants. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7795717 * chore: regenerate filenames.libcxx.gni Removed ctype.h, fenv.h, and inttypes.h which were deleted upstream. * chore: remove obsolete siso patches Upstream rewrote file_parser.go's readFile to use mmapfile.Read instead of os.Open + chunked ReadAt goroutines. The race condition in bindflt.sys that these patches worked around (redundant CreateFileW calls under concurrent opens) can no longer occur with the new mmap-based approach. Also guard the git am step against an empty patches directory. * chore: bump chromium in DEPS to 150.0.7843.0 * chore: bump chromium in DEPS to 150.0.7844.0 * fix(patch-conflict): update mas patch for CATransactionV2 feature guard Upstream guarded the CAContext reallocation on resize behind the kCATransactionV2 feature flag. Updated the MAS build guard to preserve this new condition alongside the existing allow_remote_layers_ check. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7850052 Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> * chore: update patch hunk headers Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> * fixup! 7836112: inline media_capture_util after upstream removal * fixup! chore: remove obsolete siso patches * 7832184: [asm.js] Disable asm.js-to-Wasm translation The codepath that produced the warning this Node.js test was asserting on is no longer taken after the upstream change. Refs https://chromium-review.googlesource.com/c/v8/v8/+/7832184 * chore: update patches * chore: back out unrelated formatting changes --------- (cherry picked from commit 23af5c4) Skip-Lint: cherry-pick of #51610 * chore: bump chromium to 150.0.7847.0 (main) (#51720) * chore: bump chromium in DEPS to 150.0.7847.0 * chore: update patches * 7845702: Speculative fix for pdf summarize button on ChromeOS. Refs https://chromium-review.googlesource.com/c/chromium/src/+/7845702 --------- (cherry picked from commit 58322f7) Skip-Lint: cherry-picked from #51720 * chore: bump chromium to 150.0.7849.0 (main) (#51733) * chore: bump chromium in DEPS to 150.0.7849.0 * chore: update patches * 7850982: [MenuSimplification] Plumb UsesNativeSystemMenu through Views HWND APIs Refs https://chromium-review.googlesource.com/c/chromium/src/+/7850982 * 7789842: views: Add Windows-only support for excluding Widgets from screen capture Refs https://chromium-review.googlesource.com/c/chromium/src/+/7789842 Assisted-by: Claude Opus 4.7 --------- (cherry picked from commit 9b0fb5b) Skip-Lint: cherry picked from #51733 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Updating Chromium to 150.0.7844.0.
See all changes in 150.0.7834.0..150.0.7844.0
Notes: Updated Chromium to 150.0.7844.0.