Skip to content

chore: update breaking changes for Electron 42#51548

Merged
VerteDinde merged 2 commits into
mainfrom
gtk-show-hidden-files
May 7, 2026
Merged

chore: update breaking changes for Electron 42#51548
VerteDinde merged 2 commits into
mainfrom
gtk-show-hidden-files

Conversation

@VerteDinde

Copy link
Copy Markdown
Member

Description of Change

This PR documents the removal of 'showHiddenFiles' property in Linux dialogs.

Checklist

Release Notes

Notes: none

Document removal of 'showHiddenFiles' property in Linux dialogs.
@VerteDinde VerteDinde requested a review from a team as a code owner May 7, 2026 18:46
@VerteDinde VerteDinde added semver/none target/42-x-y PR should also be added to the "42-x-y" branch. target/43-x-y PR should also be added to the "43-x-y" branch. labels May 7, 2026
@electron-cation electron-cation Bot added the new-pr 🌱 PR opened recently label May 7, 2026

@erickzhao erickzhao left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs: lgtm

@electron-docs-reviewer electron-docs-reviewer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on behalf of the Electron Docs Team

Comment thread docs/breaking-changes.md Outdated
### Removed: `showHiddenFiles` in Dialogs on Linux

This property will still be honored on macOS and Windows, but support on Linux
will be removed in Electron 42. GTK intends for this to be a user choice rather

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
will be removed in Electron 42. GTK intends for this to be a user choice rather
was removed in Electron 42. GTK intends for this to be a user choice rather

Just to make sure, did you verify it was actually removed?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussion in Slack shows this was never removed! We probably should not have mentioned the specific version here, changing this to a "future version of Electron"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue to track the removal: #46817

@ckerr ckerr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, did we actually remove this? I thought this was left out of the 42 release notes because we forgot to remove it in time for 42 😆

Last commit I see with the string showHiddenFiles in it is #51406

Removed mention of 'showHiddenFiles' in Dialogs on Linux and updated deprecation notice.
@VerteDinde VerteDinde enabled auto-merge (squash) May 7, 2026 19:11
@VerteDinde VerteDinde merged commit a2a8238 into main May 7, 2026
36 checks passed
@VerteDinde VerteDinde deleted the gtk-show-hidden-files branch May 7, 2026 19:17
@release-clerk

release-clerk Bot commented May 7, 2026

Copy link
Copy Markdown

No Release Notes

@trop

trop Bot commented May 7, 2026

Copy link
Copy Markdown
Contributor

I have automatically backported this PR to "42-x-y", please check out #51550

@trop trop Bot added the in-flight/42-x-y label May 7, 2026
@trop

trop Bot commented May 7, 2026

Copy link
Copy Markdown
Contributor

I have automatically backported this PR to "43-x-y", please check out #51551

@trop trop Bot added in-flight/43-x-y merged/42-x-y PR was merged to the "42-x-y" branch. merged/43-x-y PR was merged to the "43-x-y" branch. and removed target/42-x-y PR should also be added to the "42-x-y" branch. target/43-x-y PR should also be added to the "43-x-y" branch. in-flight/42-x-y in-flight/43-x-y labels May 7, 2026
@nikwen nikwen added target/40-x-y PR should also be added to the "40-x-y" branch. target/41-x-y PR should also be added to the "41-x-y" branch. labels May 7, 2026
@nikwen nikwen removed target/40-x-y PR should also be added to the "40-x-y" branch. target/41-x-y PR should also be added to the "41-x-y" branch. labels May 7, 2026
@nikwen

nikwen commented May 7, 2026

Copy link
Copy Markdown
Member

Sorry, added the labels to the wrong PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged/42-x-y PR was merged to the "42-x-y" branch. merged/43-x-y PR was merged to the "43-x-y" branch. new-pr 🌱 PR opened recently semver/none

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants