Skip to content

docs: fix version of deprecation notice#51406

Merged
dsanders11 merged 1 commit into
mainfrom
nikwen/breaking-change
Apr 30, 2026
Merged

docs: fix version of deprecation notice#51406
dsanders11 merged 1 commit into
mainfrom
nikwen/breaking-change

Conversation

@nikwen

@nikwen nikwen commented Apr 30, 2026

Copy link
Copy Markdown
Member

Description of Change

The decision was made to postpone the deprecation until v41, but the breaking changes entry wasn't moved to the correct section in the breaking changes document.

Checklist

Release Notes

Notes: none

@nikwen nikwen requested a review from a team as a code owner April 30, 2026 15:24
@nikwen nikwen added semver/none target/41-x-y PR should also be added to the "41-x-y" branch. target/42-x-y PR should also be added to the "42-x-y" branch. labels Apr 30, 2026
@electron-cation electron-cation Bot added the new-pr 🌱 PR opened recently label Apr 30, 2026
This was referenced Apr 30, 2026
Open
Closed
erickzhao
erickzhao approved these changes Apr 30, 2026
View reviewed changes

@erickzhao erickzhao left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs: lgtm

electron-docs-reviewer[bot]
electron-docs-reviewer Bot approved these changes Apr 30, 2026
View reviewed changes

@electron-docs-reviewer electron-docs-reviewer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on behalf of the Electron Docs Team

@dsanders11 dsanders11 merged commit aaf3289 into main Apr 30, 2026
50 checks passed
@dsanders11 dsanders11 deleted the nikwen/breaking-change branch April 30, 2026 23:14
@release-clerk

release-clerk Bot commented Apr 30, 2026

Copy link
Copy Markdown

No Release Notes

This was referenced Apr 30, 2026
Merged
Merged
@trop

trop Bot commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

I have automatically backported this PR to "41-x-y", please check out #51422

@trop trop Bot added in-flight/41-x-y and removed target/41-x-y PR should also be added to the "41-x-y" branch. labels Apr 30, 2026
@trop

trop Bot commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

I have automatically backported this PR to "42-x-y", please check out #51423

@trop trop Bot added in-flight/42-x-y merged/42-x-y PR was merged to the "42-x-y" branch. merged/41-x-y PR was merged to the "41-x-y" branch. and removed target/42-x-y PR should also be added to the "42-x-y" branch. in-flight/42-x-y in-flight/41-x-y labels Apr 30, 2026
@ckerr ckerr mentioned this pull request May 7, 2026
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ckerr ckerr ckerr approved these changes

@jkleinsc jkleinsc jkleinsc approved these changes

@dsanders11 dsanders11 dsanders11 approved these changes

@electron-docs-reviewer electron-docs-reviewer[bot] electron-docs-reviewer[bot] approved these changes

+1 more reviewer

@erickzhao erickzhao erickzhao approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

merged/41-x-y PR was merged to the "41-x-y" branch. merged/42-x-y PR was merged to the "42-x-y" branch. new-pr 🌱 PR opened recently semver/none

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nikwen @ckerr @jkleinsc @dsanders11 @erickzhao