ci: pin Homebrew version in CI runs#51543
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Hello @nmggithub! It looks like this pull request touches one of our dependency or CI files, and per our contribution policy we do not accept these types of changes in PRs.
To move this PR forward, please:
- Revert the dependency/CI file changes from your branch. (e.g.
yarn.lock,.yarn/,.yarnrc.yml,.github/workflows/,.github/actions/) - Ensure your branch allows maintainer commits so a maintainer can push the necessary dependency changes on your behalf.
- Leave a comment letting reviewers know the dependency change is still needed.
For maintainers
To land this PR, push a verified commit to the contributor's branch with the required dependency/CI changes, then dismiss this review.
4 tasks
jkleinsc
approved these changes
May 7, 2026
|
No Release Notes |
Contributor
|
I was unable to backport this PR to "40-x-y" cleanly; |
This was referenced May 7, 2026
Contributor
|
I have automatically backported this PR to "42-x-y", please check out #51545 |
Contributor
|
I have automatically backported this PR to "43-x-y", please check out #51546 |
Contributor
|
I have automatically backported this PR to "41-x-y", please check out #51547 |
Contributor
|
@nmggithub has manually backported this PR to "40-x-y", please check out #51555 |
jkleinsc
pushed a commit
that referenced
this pull request
May 8, 2026
ci: pin Homebrew version in CI runs (#51543) * feat: pin Homebrew version in CI runs * feat: validate Homebrew asset before installing * fix: fix sha256 verificaton * fix: inline sha256 check * fix: remove GitHub CLI integrity check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
We had a recent macOS build that failed in CI due to a bug in Homebrew: https://github.com/electron/electron/actions/runs/25497330347
This appears to be fixed in a newer version of Homebrew (5.1.10) via this commit: Homebrew/brew@1c8cbf3 (Homebrew/brew#22137)
However, it seems we currently just use whatever version of Homebrew is on our runners. For better control, we might be better served pinning the Homebrew version ourselves and installing it via their published
.pkgfiles.Checklist
Release Notes
Notes: none.