Skip to content

fix: improve resize band positioning and scaling for frameless windows on Windows#51503

Merged
jkleinsc merged 1 commit into
electron:mainfrom
mitchchn:fix-resize-handle-dpi-and-overlap
May 7, 2026
Merged

fix: improve resize band positioning and scaling for frameless windows on Windows#51503
jkleinsc merged 1 commit into
electron:mainfrom
mitchchn:fix-resize-handle-dpi-and-overlap

Conversation

@mitchchn

@mitchchn mitchchn commented May 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Description of Change

Fixes #51497, fixes #51385.

External resize bands on frameless windows are now larger at higher display scales instead of always using the DIP value. They also no longer appear inside the window except at the top (the old hit test logic is suppressed).

41.x,42.x

Checklist

Release Notes

Notes: Improved external resize band positioning and scaling for frameless windows on Windows.

@electron-cation electron-cation Bot added the new-pr 🌱 PR opened recently label May 5, 2026
@mitchchn mitchchn force-pushed the fix-resize-handle-dpi-and-overlap branch from 5cdc236 to 7fc849c Compare May 5, 2026 16:38
@mitchchn mitchchn marked this pull request as ready for review May 5, 2026 17:14
@mitchchn mitchchn force-pushed the fix-resize-handle-dpi-and-overlap branch 5 times, most recently from 85390f0 to 8756725 Compare May 5, 2026 22:55
@mitchchn mitchchn force-pushed the fix-resize-handle-dpi-and-overlap branch from 8756725 to fecce41 Compare May 6, 2026 02:01
@ckerr ckerr added target/41-x-y PR should also be added to the "41-x-y" branch. target/42-x-y PR should also be added to the "42-x-y" branch. labels May 6, 2026
@github-actions github-actions Bot added the target/43-x-y PR should also be added to the "43-x-y" branch. label May 6, 2026
@jkleinsc jkleinsc added the semver/patch backwards-compatible bug fixes label May 7, 2026
@electron-cation electron-cation Bot added new-pr 🌱 PR opened recently and removed new-pr 🌱 PR opened recently labels May 7, 2026
@jkleinsc jkleinsc merged commit efe652c into electron:main May 7, 2026
83 checks passed
@release-clerk

release-clerk Bot commented May 7, 2026

Copy link
Copy Markdown

Release Notes Persisted

Improved external resize band positioning and scaling for frameless windows on Windows.

@trop

trop Bot commented May 7, 2026

Copy link
Copy Markdown
Contributor

I was unable to backport this PR to "41-x-y" cleanly;
you will need to perform this backport manually.

@trop trop Bot removed the target/41-x-y PR should also be added to the "41-x-y" branch. label May 7, 2026
@trop

trop Bot commented May 7, 2026

Copy link
Copy Markdown
Contributor

I was unable to backport this PR to "42-x-y" cleanly;
you will need to perform this backport manually.

@trop trop Bot added needs-manual-bp/41-x-y needs-manual-bp/42-x-y and removed target/42-x-y PR should also be added to the "42-x-y" branch. labels May 7, 2026
@trop trop Bot mentioned this pull request May 7, 2026
Merged
@trop

trop Bot commented May 7, 2026

Copy link
Copy Markdown
Contributor

I have automatically backported this PR to "43-x-y", please check out #51552

@trop trop Bot added the in-flight/43-x-y label May 7, 2026
@trop trop Bot removed the target/43-x-y PR should also be added to the "43-x-y" branch. label May 7, 2026
@mitchchn mitchchn mentioned this pull request May 8, 2026
Merged
@trop

trop Bot commented May 8, 2026

Copy link
Copy Markdown
Contributor

@mitchchn has manually backported this PR to "41-x-y", please check out #51560

@mitchchn mitchchn mentioned this pull request May 8, 2026
Merged
@trop

trop Bot commented May 8, 2026

Copy link
Copy Markdown
Contributor

@mitchchn has manually backported this PR to "42-x-y", please check out #51561

mitchchn added a commit to mitchchn/electron that referenced this pull request May 8, 2026
@mitchchn
fix: improve resize band positioning and scaling for frameless window…
30f5a66 
…s on Windows (electron#51503)

fix internal resize and scaling for frameless windows
mitchchn added a commit to mitchchn/electron that referenced this pull request May 8, 2026
@mitchchn
fix: improve resize band positioning and scaling for frameless window…
a6da6f7 
…s on Windows (electron#51503)

fix internal resize and scaling for frameless windows
mitchchn added a commit to mitchchn/electron that referenced this pull request May 8, 2026
@mitchchn
fix: improve resize band positioning and scaling for frameless window…
cd23d0e 
…s on Windows (electron#51503)

fix internal resize and scaling for frameless windows
ckerr pushed a commit that referenced this pull request May 8, 2026
@mitchchn
fix: improve resize band positioning and scaling for frameless window…
c6800ea 
…s on Windows (#51560)

fix: improve resize band positioning and scaling for frameless windows on Windows (#51503)

fix internal resize and scaling for frameless windows
@trop trop Bot added merged/41-x-y PR was merged to the "41-x-y" branch. merged/43-x-y PR was merged to the "43-x-y" branch. and removed in-flight/41-x-y in-flight/43-x-y labels May 8, 2026
mitchchn added a commit to mitchchn/electron that referenced this pull request May 16, 2026
@mitchchn
fix: improve resize band positioning and scaling for frameless window…
8d3cdbd 
…s on Windows (electron#51503)

fix internal resize and scaling for frameless windows
mitchchn added a commit to mitchchn/electron that referenced this pull request May 22, 2026
@mitchchn
fix: improve resize band positioning and scaling for frameless window…
1fe4a7c 
…s on Windows (electron#51503)

fix internal resize and scaling for frameless windows
mitchchn added a commit to mitchchn/electron that referenced this pull request May 26, 2026
@mitchchn
fix: improve resize band positioning and scaling for frameless window…
2f1c949 
…s on Windows (electron#51503)

fix internal resize and scaling for frameless windows
mitchchn added a commit to mitchchn/electron that referenced this pull request May 30, 2026
@mitchchn
fix: improve resize band positioning and scaling for frameless window…
e9c34ca 
…s on Windows (electron#51503)

fix internal resize and scaling for frameless windows
dsanders11 pushed a commit that referenced this pull request Jun 2, 2026
@mitchchn
fix: improve resize band positioning and scaling for frameless window…
9c669aa 
…s on Windows (#51561)

fix: improve resize band positioning and scaling for frameless windows on Windows (#51503)

fix internal resize and scaling for frameless windows
@trop trop Bot added merged/42-x-y PR was merged to the "42-x-y" branch. and removed in-flight/42-x-y labels Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ckerr ckerr ckerr approved these changes

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees

No one assigned

Labels

merged/41-x-y PR was merged to the "41-x-y" branch. merged/42-x-y PR was merged to the "42-x-y" branch. merged/43-x-y PR was merged to the "43-x-y" branch. semver/patch backwards-compatible bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Resize handle both inside and outside frameless window Resize handle size does not adapt to dpi

3 participants

@mitchchn @ckerr @jkleinsc