fix: crash in AutofillPopup teardown#51302
Merged
Merged
Conversation
codebytere
approved these changes
Apr 24, 2026
0704d06 to
17ee08b
Compare
Fix a crash in AutofillPopupView::Show() when the popup tried to show itself after the parent's native view had already gone away during teardown. 2026-04-23T20:44:32.7015810Z Received signal 11 SEGV_ACCERR 000000000160 2026-04-23T20:44:32.9322010Z 4 Electron Framework ... views::Widget::IsVisible() const + 28 2026-04-23T20:44:32.9528810Z 6 Electron Framework ... electron::AutofillPopupView::Show() + 200 2026-04-23T20:44:32.9632090Z 7 Electron Framework ... electron::AutofillPopup::CreateView(...) + 1380 2026-04-23T20:44:32.9749770Z 8 Electron Framework ... electron::AutofillDriver::ShowAutofillPopup(...) + 736 2026-04-23T20:44:33.0015220Z ✗ Electron tests failed with kill signal SIGSEGV.
17ee08b to
a2d5e61
Compare
Member
Author
|
(force-pushed to pick up CI fixes in |
deepak1556
approved these changes
Apr 25, 2026
|
Release Notes Persisted
|
Contributor
|
I was unable to backport this PR to "40-x-y" cleanly; |
Contributor
|
I was unable to backport this PR to "41-x-y" cleanly; |
Contributor
|
I have automatically backported this PR to "42-x-y", please check out #51317 |
Contributor
5 tasks
codebytere
pushed a commit
that referenced
this pull request
Apr 27, 2026
fix: crash in AutofillPopup teardown (#51302) Fix a crash in AutofillPopupView::Show() when the popup tried to show itself after the parent's native view had already gone away during teardown. 2026-04-23T20:44:32.7015810Z Received signal 11 SEGV_ACCERR 000000000160 2026-04-23T20:44:32.9322010Z 4 Electron Framework ... views::Widget::IsVisible() const + 28 2026-04-23T20:44:32.9528810Z 6 Electron Framework ... electron::AutofillPopupView::Show() + 200 2026-04-23T20:44:32.9632090Z 7 Electron Framework ... electron::AutofillPopup::CreateView(...) + 1380 2026-04-23T20:44:32.9749770Z 8 Electron Framework ... electron::AutofillDriver::ShowAutofillPopup(...) + 736 2026-04-23T20:44:33.0015220Z ✗ Electron tests failed with kill signal SIGSEGV.
ckerr
added a commit
that referenced
this pull request
Apr 27, 2026
fix: crash in AutofillPopup teardown (#51302) Fix a crash in AutofillPopupView::Show() when the popup tried to show itself after the parent's native view had already gone away during teardown. 2026-04-23T20:44:32.7015810Z Received signal 11 SEGV_ACCERR 000000000160 2026-04-23T20:44:32.9322010Z 4 Electron Framework ... views::Widget::IsVisible() const + 28 2026-04-23T20:44:32.9528810Z 6 Electron Framework ... electron::AutofillPopupView::Show() + 200 2026-04-23T20:44:32.9632090Z 7 Electron Framework ... electron::AutofillPopup::CreateView(...) + 1380 2026-04-23T20:44:32.9749770Z 8 Electron Framework ... electron::AutofillDriver::ShowAutofillPopup(...) + 736 2026-04-23T20:44:33.0015220Z ✗ Electron tests failed with kill signal SIGSEGV. Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr <charles@charleskerr.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix a crash that I saw in CI today. Electron is in
AutofillPopupView::Show()when the popup tries to show itself after the parent's native view has already gone away during teardown.Checklist
npm testpassesRelease Notes
Notes: Fixed a crash that could occur when an autofill suggestion popup was shown while a window was closing.