fix: deprecate ELECTRON_SKIP_BINARY_DOWNLOAD env#50406
Merged
jkleinsc merged 3 commits intoMar 24, 2026
Merged
Conversation
it is redundant as of electron v42 its purpose was to skip the binary download for post install script but as of electron v42, post install script is gone and replaced with a lazy download it was also slated for removal in [this comment](electron/rfcs#22 (comment))
the env is redundant as of electron v42 so docs don't have to mention it anymore
felixrieseberg
approved these changes
Mar 21, 2026
codebytere
approved these changes
Mar 23, 2026
jkleinsc
approved these changes
Mar 24, 2026
Member
|
Merging as CI failure unrelated to PR change. |
|
Release Notes Persisted
|
Contributor
|
I have automatically backported this PR to "42-x-y", please check out #50459 |
gwennlbh
added a commit
to cigaleapp/cigale
that referenced
this pull request
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
follow up to #50359
removes the
ELECTRON_SKIP_BINARY_DOWNLOADenv frominstall.jsas it is redundantdue to the post install script being dropped as of electron v42
(the ENVs sole purpose was to stop the postinstall script from triggering, however it is gone now, so the env is redundant)
and also adds mention of the env to the breaking changes doc
Checklist
npm testpassesRelease Notes
Notes: Removed support for the ELECTRON_SKIP_BINARY_DOWNLOAD environment variable.