Skip to content

fix: always call the original impl in swizzled mousedown impls#50096

Merged
jkleinsc merged 1 commit intoelectron:mainfrom
nmggithub:fix-devtools-resizing
Mar 18, 2026
Merged

fix: always call the original impl in swizzled mousedown impls#50096
jkleinsc merged 1 commit intoelectron:mainfrom
nmggithub:fix-devtools-resizing

Conversation

@nmggithub
Copy link
Contributor

@nmggithub nmggithub commented Mar 5, 2026 •
edited
Loading

Description of Change

Should resolve #49874. We should always call the original mousedown implementation, regardless of if our window responds to shell.

Checklist

Release Notes

Notes: Fixed logic bug that rendered certain window types un-resizable on MAS builds.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Mar 5, 2026
@ckerr ckerr added semver/patch backwards-compatible bug fixes target/39-x-y PR should also be added to the "39-x-y" branch. target/40-x-y PR should also be added to the "40-x-y" branch. target/41-x-y PR should also be added to the "41-x-y" branch. and removed target/39-x-y PR should also be added to the "39-x-y" branch. labels Mar 6, 2026
@ckerr
Copy link
Member

ckerr commented Mar 6, 2026 •
edited
Loading

Marking as target/40-x-y and target/41-x-y but I'm unsure about 39.

According to the issue description in 49874, "This appears to be a regression related to #49780 and #49391."

49780 is in 41, 40, 39.

49391 is in 41, 40. It's marked as "needs-manual-bp" for 39, 38.

Can someone with easy access to macOS test & see whether this patch is needed in 39?

@nmggithub
Copy link
Contributor Author

nmggithub commented Mar 6, 2026 •
edited
Loading

@ckerr just tested on v39. It does appear to exhibit the same behavior (unable to resize DevTools windows), so a manual backport might be needed then.

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Mar 6, 2026
@github-actions github-actions bot added the target/42-x-y PR should also be added to the "42-x-y" branch. label Mar 13, 2026
@dsanders11
Copy link
Member

dsanders11 commented Mar 16, 2026

@nmggithub, looks like CI is having trouble getting a successful run here. Could you try rebasing on main in case it's just a flaky issue?

@nmggithub nmggithub force-pushed the fix-devtools-resizing branch from 63694c7 to 4de50bb Compare March 16, 2026 19:22
@nmggithub
Copy link
Contributor Author

nmggithub commented Mar 16, 2026

@dsanders11 Just did so!

@nmggithub
Copy link
Contributor Author

nmggithub commented Mar 17, 2026

@dsanders11 build is still failing :( but it looks like a CI issue. Some missing token.

@dsanders11
Copy link
Member

dsanders11 commented Mar 18, 2026

@nmggithub, this is now only failing on a test job timing out, I think it would benefit from another rebase on main to pick up #50305 which extends the timeout. Apologies for the thrash!

@nmggithub nmggithub force-pushed the fix-devtools-resizing branch from 4de50bb to 89b99b1 Compare March 18, 2026 17:24
@nmggithub
Copy link
Contributor Author

nmggithub commented Mar 18, 2026

@dsanders11 Just rebased again. Hopefully it works this time!

@jkleinsc jkleinsc merged commit b881f86 into electron:main Mar 18, 2026
63 checks passed
@release-clerk
Copy link

release-clerk bot commented Mar 18, 2026

Release Notes Persisted

Fixed logic bug that rendered certain window types un-resizable on MAS builds.

This was referenced Mar 18, 2026
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Mar 18, 2026

I have automatically backported this PR to "41-x-y", please check out #50354

@trop trop bot added in-flight/41-x-y and removed target/41-x-y PR should also be added to the "41-x-y" branch. labels Mar 18, 2026
@trop
Copy link
Contributor

trop bot commented Mar 18, 2026

I have automatically backported this PR to "40-x-y", please check out #50355

@trop
Copy link
Contributor

trop bot commented Mar 18, 2026

I have automatically backported this PR to "42-x-y", please check out #50356

@trop trop bot added in-flight/40-x-y in-flight/42-x-y merged/41-x-y PR was merged to the "41-x-y" branch. merged/42-x-y PR was merged to the "42-x-y" branch. merged/40-x-y PR was merged to the "40-x-y" branch. and removed target/40-x-y PR should also be added to the "40-x-y" branch. target/42-x-y PR should also be added to the "42-x-y" branch. in-flight/41-x-y in-flight/42-x-y in-flight/40-x-y labels Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ckerr ckerr ckerr approved these changes

@jkleinsc jkleinsc jkleinsc approved these changes

@codebytere codebytere codebytere approved these changes

@dsanders11 dsanders11 dsanders11 approved these changes

Assignees

No one assigned

Labels

merged/40-x-y PR was merged to the "40-x-y" branch. merged/41-x-y PR was merged to the "41-x-y" branch. merged/42-x-y PR was merged to the "42-x-y" branch. semver/patch backwards-compatible bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unable to resize Developer Tools window in MAS build

5 participants

@nmggithub @ckerr @dsanders11 @jkleinsc @codebytere