Skip to content

fix: rgbaf16 shared texture remove keyed mutex.#49798

Merged
jkleinsc merged 3 commits into
electron:mainfrom
reitowo:main-fix-osr-patch-rgbaf16
Feb 19, 2026
Merged

fix: rgbaf16 shared texture remove keyed mutex.#49798
jkleinsc merged 3 commits into
electron:mainfrom
reitowo:main-fix-osr-patch-rgbaf16

Conversation

@reitowo

@reitowo reitowo commented Feb 13, 2026

Copy link
Copy Markdown
Member

Description of Change

Fixed an issue that caused the RGBAF16 shared texture format to have a keyed mutex on Windows.

Closes #49752

Release Notes

Notes: Fixed an issue that caused the RGBAF16 shared texture format to have a keyed mutex on Windows.

@reitowo reitowo force-pushed the main-fix-osr-patch-rgbaf16 branch from 8e06798 to d4ffe7b Compare February 14, 2026 03:19

@jkleinsc jkleinsc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, just needs small documentation improvement.

@jkleinsc jkleinsc added the semver/patch backwards-compatible bug fixes label Feb 17, 2026
@electron-cation electron-cation Bot removed the new-pr 🌱 PR opened recently label Feb 17, 2026
@jkleinsc jkleinsc added target/40-x-y PR should also be added to the "40-x-y" branch. target/41-x-y PR should also be added to the "41-x-y" branch. labels Feb 17, 2026
@reitowo

reitowo commented Feb 18, 2026

Copy link
Copy Markdown
Member Author

Hi @jkleinsc I couldn't see your comment, am I missing something?

@jkleinsc jkleinsc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry @reitowo here's my suggestion

Comment thread docs/api/structures/shared-texture-handle.md Outdated
Co-authored-by: John Kleinschmidt <kleinschmidtorama@gmail.com>
@codebytere codebytere requested a review from jkleinsc February 19, 2026 09:32
@jkleinsc jkleinsc merged commit 491fa04 into electron:main Feb 19, 2026
107 of 110 checks passed
@release-clerk

release-clerk Bot commented Feb 19, 2026

Copy link
Copy Markdown

Release Notes Persisted

Fixed an issue that caused the RGBAF16 shared texture format to have a keyed mutex on Windows.

@trop

trop Bot commented Feb 19, 2026

Copy link
Copy Markdown
Contributor

I was unable to backport this PR to "40-x-y" cleanly;
you will need to perform this backport manually.

@trop trop Bot added needs-manual-bp/40-x-y and removed target/40-x-y PR should also be added to the "40-x-y" branch. labels Feb 19, 2026
@trop

trop Bot commented Feb 19, 2026

Copy link
Copy Markdown
Contributor

I have automatically backported this PR to "41-x-y", please check out #49876

@trop trop Bot added in-flight/41-x-y merged/41-x-y PR was merged to the "41-x-y" branch. and removed target/41-x-y PR should also be added to the "41-x-y" branch. in-flight/41-x-y labels Feb 19, 2026
kycutler pushed a commit to kycutler/electron that referenced this pull request Feb 26, 2026
* fix: rgbaf16 shared texture remove keyed mutex.

* fix: rgbaf16 patch.

* 更新 shared-texture-handle.md

Co-authored-by: John Kleinschmidt <kleinschmidtorama@gmail.com>

---------

Co-authored-by: John Kleinschmidt <kleinschmidtorama@gmail.com>
@trop

This comment was marked as outdated.

@trop

trop Bot commented May 19, 2026

Copy link
Copy Markdown
Contributor

@ckerr has manually backported this PR to "40-x-y", please check out #51701

@trop trop Bot added merged/40-x-y PR was merged to the "40-x-y" branch. and removed in-flight/40-x-y labels May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged/40-x-y PR was merged to the "40-x-y" branch. merged/41-x-y PR was merged to the "41-x-y" branch. semver/patch backwards-compatible bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OSR RGBAF16 textures and ARGB textures have different properties on Windows

3 participants