fix(squirrel.mac): clean up old staged updates before downloading new update#49365
Merged
jkleinsc merged 1 commit intoelectron:mainfrom Feb 3, 2026
Merged
fix(squirrel.mac): clean up old staged updates before downloading new update#49365jkleinsc merged 1 commit intoelectron:mainfrom
jkleinsc merged 1 commit intoelectron:mainfrom
Conversation
loc
commented
Jan 12, 2026
When checkForUpdates() is called while an update is already staged, Squirrel creates a new temporary directory for the download without cleaning up the old one. This can lead to disk usage growth when new versions are released while the app hasn't restarted. This adds a force parameter to pruneUpdateDirectories that bypasses the AwaitingRelaunch state check. This is called before creating a new temp directory, ensuring old staged updates are cleaned up.
f121d07 to
925c441
Compare
MarshallOfSound
approved these changes
Jan 28, 2026
Member
MarshallOfSound
left a comment
There was a problem hiding this comment.
@codebytere can you take a look too, but seems fine to me
VerteDinde
approved these changes
Jan 31, 2026
codebytere
approved these changes
Feb 3, 2026
jkleinsc
approved these changes
Feb 3, 2026
Member
|
Merging as CI failure unrelated to PR change. |
|
Release Notes Persisted
|
This was referenced Feb 3, 2026
Contributor
|
I have automatically backported this PR to "39-x-y", please check out #49637 |
Contributor
|
I have automatically backported this PR to "40-x-y", please check out #49638 |
Contributor
|
I have automatically backported this PR to "41-x-y", please check out #49639 |
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
When checkForUpdates() is called while an update is already staged, Squirrel creates a new temporary directory for the download without cleaning up the old one. This can lead to disk usage growth when new versions are released while the app hasn't restarted.
This adds a force parameter to pruneUpdateDirectories that bypasses the AwaitingRelaunch state check. This is called before creating a new temp directory, ensuring old staged updates are cleaned up.
Checklist
npm testpassesRelease Notes
Notes: fixed squirrel.mac stacked update behavior to old staged updates