fix: logical bug in install.js env var handling #48634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If either `npm_config_electron_use_remote_checksums` or `electron_use_remote_checksums` are set as environment variables, then force Electron to verify with remote checksums instead of embedded ones. Fixes #48594.
This was referenced Oct 22, 2025
nikwen
approved these changes
Oct 23, 2025
| force: process.env.force_no_cache === 'true', | ||
| cacheRoot: process.env.electron_config_cache, | ||
| checksums: process.env.electron_use_remote_checksums ?? process.env.npm_config_electron_use_remote_checksums ? undefined : require('./checksums.json'), | ||
| checksums: (process.env.electron_use_remote_checksums || process.env.npm_config_electron_use_remote_checksums) ? undefined : require('./checksums.json'), |
Member
There was a problem hiding this comment.
Just noting that this is a behavior change for rare cases where electron_use_remote_checksums is false and npm_config_electron_use_remote_checksums is true (if that is even possible). Should be fine though because that's unlikely.
codebytere
approved these changes
Oct 23, 2025
jkleinsc
approved these changes
Oct 23, 2025
dsanders11
approved these changes
Oct 24, 2025
|
Release Notes Persisted
|
This was referenced Oct 27, 2025
Contributor
|
I have automatically backported this PR to "37-x-y", please check out #48671 |
Contributor
|
I have automatically backported this PR to "38-x-y", please check out #48672 |
Contributor
|
I have automatically backported this PR to "39-x-y", please check out #48673 |
TheCommieAxolotl
pushed a commit
to TheCommieAxolotl/electron
that referenced
this pull request
Nov 2, 2025
If either `npm_config_electron_use_remote_checksums` or `electron_use_remote_checksums` are set as environment variables, then force Electron to verify with remote checksums instead of embedded ones. Fixes electron#48594.
nilayarya
pushed a commit
to nilayarya/electron
that referenced
this pull request
Nov 21, 2025
If either `npm_config_electron_use_remote_checksums` or `electron_use_remote_checksums` are set as environment variables, then force Electron to verify with remote checksums instead of embedded ones. Fixes electron#48594.
nilayarya
added a commit
to nilayarya/electron
that referenced
this pull request
Nov 21, 2025
If either `npm_config_electron_use_remote_checksums` or `electron_use_remote_checksums` are set as environment variables, then force Electron to verify with remote checksums instead of embedded ones. Fixes electron#48594.
nilayarya
added a commit
to nilayarya/electron
that referenced
this pull request
Nov 21, 2025
If either `npm_config_electron_use_remote_checksums` or `electron_use_remote_checksums` are set as environment variables, then force Electron to verify with remote checksums instead of embedded ones. Fixes electron#48594.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
If either
NPM_CONFIG_ELECTRON_USE_REMOTE_CHECKSUMSorELECTRON_USE_REMOTE_CHECKSUMSare set as environment variables, then force Electron to verify with remote checksums instead of embedded ones.Fixes #48594.
Thanks to @KinshukSS2 for reporting this and suggesting a solution.
Checklist
npm testpassesRelease Notes
Notes: Fixed an error when checking environmental variables when using remote checksums when installing Electron via npm.