Skip to content

fix: icon in Windows toast notification#48543

Merged
jkleinsc merged 1 commit intomainfrom
fix-toast-template-icon
Oct 21, 2025
Merged

fix: icon in Windows toast notification#48543
jkleinsc merged 1 commit intomainfrom
fix-toast-template-icon

Conversation

@codebytere
Copy link
Copy Markdown
Member

@codebytere codebytere commented Oct 13, 2025 •
edited
Loading

Description of Change

Closes #48536.
Refs f28d08a

The image attribute should have an ID. Also cleaned up and added checks for missing icons when saving an icon to the filesystem for use in a toast.

Checklist

Release Notes

Notes: Fixed an issue where icons didn't show up as expected on Windows Toast notifications.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/37-x-y PR should also be added to the "37-x-y" branch. target/38-x-y PR should also be added to the "38-x-y" branch. target/39-x-y PR should also be added to the "39-x-y" branch. labels Oct 13, 2025
@electron-cation electron-cation bot added new-pr 🌱 PR opened recently and removed new-pr 🌱 PR opened recently labels Oct 13, 2025
@FatCatClient FatCatClient mentioned this pull request Oct 14, 2025
Closed
deepak1556
deepak1556 reviewed Oct 15, 2025
View reviewed changes
@codebytere codebytere force-pushed the fix-toast-template-icon branch 3 times, most recently from e354108 to 4958240 Compare October 15, 2025 09:08
@codebytere codebytere requested a review from deepak1556 October 15, 2025 09:09
@codebytere codebytere force-pushed the fix-toast-template-icon branch 3 times, most recently from a1f5c4a to dd5befa Compare October 15, 2025 09:14
deepak1556
deepak1556 reviewed Oct 15, 2025
View reviewed changes
@codebytere codebytere force-pushed the fix-toast-template-icon branch from 371960a to 1894c4d Compare October 16, 2025 08:04
@codebytere codebytere force-pushed the fix-toast-template-icon branch from 1894c4d to d39e061 Compare October 16, 2025 08:49
deepak1556
deepak1556 approved these changes Oct 16, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jkleinsc jkleinsc merged commit f784ea6 into main Oct 21, 2025
147 of 150 checks passed
@release-clerk
Copy link
Copy Markdown

release-clerk bot commented Oct 21, 2025

Release Notes Persisted

Fixed an issue where icons didn't show up as expected on Windows Toast notifications.

@jkleinsc jkleinsc deleted the fix-toast-template-icon branch October 21, 2025 19:12
@trop
Copy link
Copy Markdown
Contributor

trop bot commented Oct 21, 2025

I was unable to backport this PR to "37-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot added needs-manual-bp/37-x-y and removed target/37-x-y PR should also be added to the "37-x-y" branch. labels Oct 21, 2025
This was referenced Oct 21, 2025
Merged
Merged
@trop
Copy link
Copy Markdown
Contributor

trop bot commented Oct 21, 2025

I have automatically backported this PR to "39-x-y", please check out #48629

@trop
Copy link
Copy Markdown
Contributor

trop bot commented Oct 21, 2025

I have automatically backported this PR to "38-x-y", please check out #48630

@trop trop bot added in-flight/38-x-y merged/39-x-y PR was merged to the "39-x-y" branch. merged/38-x-y PR was merged to the "38-x-y" branch. and removed target/39-x-y PR should also be added to the "39-x-y" branch. target/38-x-y PR should also be added to the "38-x-y" branch. in-flight/39-x-y in-flight/38-x-y labels Oct 21, 2025
TheCommieAxolotl pushed a commit to TheCommieAxolotl/electron that referenced this pull request Nov 2, 2025
@codebytere @TheCommieAxolotl
fix: icon in Windows toast notification (electron#48543)
3f25537
nilayarya pushed a commit to nilayarya/electron that referenced this pull request Nov 21, 2025
@codebytere
fix: icon in Windows toast notification (electron#48543)
3226bbb
nilayarya added a commit to nilayarya/electron that referenced this pull request Nov 21, 2025
@nilayarya
fix: icon in Windows toast notification (electron#48543)
17ccbb9
nilayarya added a commit to nilayarya/electron that referenced this pull request Nov 21, 2025
@nilayarya
fix: icon in Windows toast notification (electron#48543)
7491f8d
@Myriam-Bora Myriam-Bora mentioned this pull request Mar 24, 2026
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

@ckerr ckerr Awaiting requested review from ckerr

@mlaurencin mlaurencin Awaiting requested review from mlaurencin

Assignees

No one assigned

Labels

merged/38-x-y PR was merged to the "38-x-y" branch. merged/39-x-y PR was merged to the "39-x-y" branch. semver/patch backwards-compatible bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Desktop notifications do not show icons on Windows

3 participants

@codebytere @jkleinsc @deepak1556