Skip to content

fix: systemPreferences.getAccentColor inverted color #48511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jkleinsc merged 1 commit into from
Oct 21, 2025
Merged

fix: systemPreferences.getAccentColor inverted color #48511

jkleinsc merged 1 commit into from
Oct 21, 2025

Conversation

@codebytere
Copy link
Member

@codebytere codebytere commented Oct 10, 2025

Description of Change

Closes #48506.

Fixes an issue where systemPreferences.getAccentColor inverted the color.

Checklist

Release Notes

Notes: Fixed an issue where systemPreferences.getAccentColor inverted the color.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Oct 10, 2025
@codebytere codebytere changed the title fix: systemPreferences.getAccentColor inverted color fix: systemPreferences.getAccentColor inverted color Oct 10, 2025
@codebytere codebytere added semver/patch backwards-compatible bug fixes target/36-x-y PR should also be added to the "36-x-y" branch. target/37-x-y PR should also be added to the "37-x-y" branch. target/38-x-y PR should also be added to the "38-x-y" branch. target/39-x-y PR should also be added to the "39-x-y" branch. labels Oct 13, 2025
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Oct 13, 2025
@codebytere codebytere requested review from deepak1556 and dsanders11 and removed request for mlaurencin October 20, 2025 11:40
@jkleinsc jkleinsc merged commit 6562d6e into main Oct 21, 2025
72 checks passed
@jkleinsc jkleinsc deleted the fix-accent-getter branch October 21, 2025 14:46
@release-clerk
Copy link

release-clerk bot commented Oct 21, 2025

Release Notes Persisted

Fixed an issue where systemPreferences.getAccentColor inverted the color.

@trop
Copy link
Contributor

trop bot commented Oct 21, 2025

I was unable to backport this PR to "37-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Oct 21, 2025

I was unable to backport this PR to "36-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/37-x-y PR should also be added to the "37-x-y" branch. label Oct 21, 2025
@trop
Copy link
Contributor

trop bot commented Oct 21, 2025

I was unable to backport this PR to "38-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot added needs-manual-bp/37-x-y needs-manual-bp/36-x-y and removed target/36-x-y PR should also be added to the "36-x-y" branch. target/38-x-y PR should also be added to the "38-x-y" branch. labels Oct 21, 2025
@trop trop bot mentioned this pull request Oct 21, 2025
Merged
@trop
Copy link
Contributor

trop bot commented Oct 21, 2025

I have automatically backported this PR to "39-x-y", please check out #48624

@trop trop bot added in-flight/39-x-y merged/39-x-y PR was merged to the "39-x-y" branch. and removed target/39-x-y PR should also be added to the "39-x-y" branch. in-flight/39-x-y labels Oct 21, 2025
TheCommieAxolotl pushed a commit to TheCommieAxolotl/electron that referenced this pull request Nov 2, 2025
@codebytere @TheCommieAxolotl
fix: systemPreferences.getAccentColor inverted color (electron#48511)
41a23f7 
fix: systemPreferences.getAccentColor inverted color
nilayarya pushed a commit to nilayarya/electron that referenced this pull request Nov 21, 2025
@codebytere
fix: systemPreferences.getAccentColor inverted color (electron#48511)
d16988e 
fix: systemPreferences.getAccentColor inverted color
nilayarya added a commit to nilayarya/electron that referenced this pull request Nov 21, 2025
@nilayarya
fix: systemPreferences.getAccentColor inverted color (electron#48511)
a66af08 
fix: systemPreferences.getAccentColor inverted color
nilayarya added a commit to nilayarya/electron that referenced this pull request Nov 21, 2025
@nilayarya
fix: systemPreferences.getAccentColor inverted color (electron#48511)
bfbe470 
fix: systemPreferences.getAccentColor inverted color
@codebytere codebytere mentioned this pull request Nov 24, 2025
Merged
@trop
Copy link
Contributor

trop bot commented Nov 24, 2025

@codebytere has manually backported this PR to "38-x-y", please check out #49066

@codebytere codebytere mentioned this pull request Nov 24, 2025
Merged
@trop
Copy link
Contributor

trop bot commented Nov 24, 2025

@codebytere has manually backported this PR to "37-x-y", please check out #49067

@trop trop bot added in-flight/37-x-y merged/37-x-y PR was merged to the "37-x-y" branch. merged/38-x-y PR was merged to the "38-x-y" branch. and removed needs-manual-bp/37-x-y in-flight/37-x-y in-flight/38-x-y labels Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@ckerr ckerr Awaiting requested review from ckerr

@samuelmaddock samuelmaddock Awaiting requested review from samuelmaddock

@nikwen nikwen Awaiting requested review from nikwen

@deepak1556 deepak1556 Awaiting requested review from deepak1556

@dsanders11 dsanders11 Awaiting requested review from dsanders11

Assignees

No one assigned

Labels

merged/37-x-y PR was merged to the "37-x-y" branch. merged/38-x-y PR was merged to the "38-x-y" branch. merged/39-x-y PR was merged to the "39-x-y" branch. needs-manual-bp/36-x-y semver/patch backwards-compatible bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

systemPreferences.getAccentColor returns color-shifted values

3 participants

@codebytere @jkleinsc