Skip to content

ci: Use Local Execution, Remote Caching (LERC) for fork PRS#48319

Merged
jkleinsc merged 1 commit intomainfrom
fork-siso
Sep 15, 2025
Merged

ci: Use Local Execution, Remote Caching (LERC) for fork PRS#48319
jkleinsc merged 1 commit intomainfrom
fork-siso

Conversation

@jkleinsc
Copy link
Copy Markdown
Member

@jkleinsc jkleinsc commented Sep 15, 2025 •
edited
Loading

Description of Change

Since fork PRs only have read access to the RBE cache that siso uses, this PR fixes that error by setting the RBE exec strategy to local which has the following operation:

Use Local Execution, Remote Caching (LERC). Checks the remote cache for action matches and uses existing results if a match is found. If not, execution of the action is performed locally.

Successful builds with this strategy can be seen here: https://github.com/electron/electron/actions/runs/17739060216?pr=48320.

Checklist

Release Notes

Notes: none

MarshallOfSound
MarshallOfSound reviewed Sep 15, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we still vended anonymous tokens for fork PRs 🤔

@jkleinsc jkleinsc changed the title ci: allow anonymous siso access for fork PRs ci: Use Local Execution, Remote Caching (LERC) for fork PRS Sep 15, 2025
@jkleinsc jkleinsc added target/36-x-y PR should also be added to the "36-x-y" branch. target/37-x-y PR should also be added to the "37-x-y" branch. target/38-x-y PR should also be added to the "38-x-y" branch. target/39-x-y PR should also be added to the "39-x-y" branch. labels Sep 15, 2025
@jkleinsc jkleinsc marked this pull request as ready for review September 15, 2025 18:23
@jkleinsc jkleinsc requested a review from a team as a code owner September 15, 2025 18:23
@jkleinsc jkleinsc merged commit 49eb165 into main Sep 15, 2025
71 checks passed
@jkleinsc jkleinsc deleted the fork-siso branch September 15, 2025 20:31
@release-clerk
Copy link
Copy Markdown

release-clerk bot commented Sep 15, 2025

No Release Notes

This was referenced Sep 15, 2025
Merged
Merged
@trop
Copy link
Copy Markdown
Contributor

trop bot commented Sep 15, 2025

I have automatically backported this PR to "36-x-y", please check out #48322

@trop trop bot mentioned this pull request Sep 15, 2025
Merged
@trop trop bot added in-flight/36-x-y and removed target/36-x-y PR should also be added to the "36-x-y" branch. labels Sep 15, 2025
@trop trop bot mentioned this pull request Sep 15, 2025
Merged
@trop
Copy link
Copy Markdown
Contributor

trop bot commented Sep 15, 2025

I have automatically backported this PR to "38-x-y", please check out #48323

@trop
Copy link
Copy Markdown
Contributor

trop bot commented Sep 15, 2025

I have automatically backported this PR to "37-x-y", please check out #48324

@trop
Copy link
Copy Markdown
Contributor

trop bot commented Sep 15, 2025

I have automatically backported this PR to "39-x-y", please check out #48325

@trop trop bot added in-flight/37-x-y in-flight/39-x-y and removed target/38-x-y PR should also be added to the "38-x-y" branch. target/37-x-y PR should also be added to the "37-x-y" branch. labels Sep 15, 2025
@trop trop bot added merged/36-x-y PR was merged to the "36-x-y" branch. merged/38-x-y PR was merged to the "38-x-y" branch. merged/39-x-y PR was merged to the "39-x-y" branch. and removed target/39-x-y PR should also be added to the "39-x-y" branch. in-flight/36-x-y in-flight/38-x-y in-flight/39-x-y labels Sep 15, 2025
@samuelmaddock samuelmaddock mentioned this pull request Sep 16, 2025
Merged
5 tasks
@trop trop bot added merged/37-x-y PR was merged to the "37-x-y" branch. and removed in-flight/37-x-y labels Sep 16, 2025
This was referenced Sep 17, 2025
Merged
Merged
kigh-ota pushed a commit to kigh-ota/electron that referenced this pull request Sep 30, 2025
@jkleinsc @kigh-ota
ci: Use Local Execution, Remote Caching (LERC) for fork PRS (electron…
8da71ab 
…#48319)

cleanup
nilayarya pushed a commit to nilayarya/electron that referenced this pull request Nov 21, 2025
@jkleinsc
ci: Use Local Execution, Remote Caching (LERC) for fork PRS (electron…
96640dd 
…#48319)

cleanup
nilayarya added a commit to nilayarya/electron that referenced this pull request Nov 21, 2025
@nilayarya
ci: Use Local Execution, Remote Caching (LERC) for fork PRS (electron…
43cd2ad 
…#48319)

cleanup
nilayarya added a commit to nilayarya/electron that referenced this pull request Nov 21, 2025
@nilayarya
ci: Use Local Execution, Remote Caching (LERC) for fork PRS (electron…
1215992 
…#48319)

cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees

No one assigned

Labels

merged/36-x-y PR was merged to the "36-x-y" branch. merged/37-x-y PR was merged to the "37-x-y" branch. merged/38-x-y PR was merged to the "38-x-y" branch. merged/39-x-y PR was merged to the "39-x-y" branch. semver/none

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jkleinsc @MarshallOfSound