Skip to content

feat: enable resetting accent color #48274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jkleinsc merged 1 commit into from
Oct 21, 2025
Merged

feat: enable resetting accent color #48274

jkleinsc merged 1 commit into from
Oct 21, 2025

Conversation

@codebytere
Copy link
Member

@codebytere codebytere commented Sep 8, 2025

Description of Change

Closes #48232.

Enables resetting accent color to follow system accent settings if a previous color has been set.

Checklist

Release Notes

Notes: Enables resetting accent color to follow system accent settings if a previous color has been set via window.setAccentColor(null).

@codebytere codebytere added semver/minor backwards-compatible functionality target/37-x-y PR should also be added to the "37-x-y" branch. target/38-x-y PR should also be added to the "38-x-y" branch. target/39-x-y PR should also be added to the "39-x-y" branch. labels Sep 8, 2025
MarshallOfSound
MarshallOfSound reviewed Sep 8, 2025
View reviewed changes
@ckerr
Copy link
Member

ckerr commented Sep 11, 2025

The macos-arm64 test (darwin, 2) CI failure is unrelated to this PR; it's present in main too. Tracked @ #48291

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Sep 15, 2025
itsananderson
itsananderson reviewed Sep 18, 2025
View reviewed changes
erickzhao
erickzhao reviewed Sep 18, 2025
View reviewed changes
@codebytere codebytere force-pushed the reset-accent-color branch 2 times, most recently from 908ee22 to 6fd43ca Compare October 10, 2025 15:15
erickzhao
erickzhao reviewed Oct 16, 2025
View reviewed changes
itsananderson
itsananderson approved these changes Oct 16, 2025
View reviewed changes
Copy link
Member

@itsananderson itsananderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple comments to try to make the examples super specific, but otherwise API LGTM

erickzhao
erickzhao reviewed Oct 17, 2025
View reviewed changes
@codebytere codebytere requested a review from erickzhao October 20, 2025 11:53
@codebytere codebytere requested review from a team as code owners October 20, 2025 11:53
@jkleinsc jkleinsc merged commit 0a19176 into main Oct 21, 2025
107 of 108 checks passed
@jkleinsc jkleinsc deleted the reset-accent-color branch October 21, 2025 14:49
@release-clerk
Copy link

release-clerk bot commented Oct 21, 2025

Release Notes Persisted

Enables resetting accent color to follow system accent settings if a previous color has been set via window.setAccentColor(null).

@trop
Copy link
Contributor

trop bot commented Oct 21, 2025

I was unable to backport this PR to "37-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/37-x-y PR should also be added to the "37-x-y" branch. label Oct 21, 2025
@trop
Copy link
Contributor

trop bot commented Oct 21, 2025

I was unable to backport this PR to "39-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot added needs-manual-bp/37-x-y and removed target/39-x-y PR should also be added to the "39-x-y" branch. labels Oct 21, 2025
@trop
Copy link
Contributor

trop bot commented Oct 21, 2025

I was unable to backport this PR to "38-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot added needs-manual-bp/39-x-y needs-manual-bp/38-x-y and removed target/38-x-y PR should also be added to the "38-x-y" branch. labels Oct 21, 2025
TheCommieAxolotl pushed a commit to TheCommieAxolotl/electron that referenced this pull request Nov 2, 2025
@codebytere @TheCommieAxolotl
feat: enable resetting accent color (electron#48274)
5b6aad8
@bpasero
Copy link
Contributor

bpasero commented Nov 8, 2025

@codebytere can this be backported at least to Electron 39?

@codebytere codebytere mentioned this pull request Nov 8, 2025
Merged
@trop
Copy link
Contributor

trop bot commented Nov 8, 2025

@codebytere has manually backported this PR to "39-x-y", please check out #48852

@codebytere codebytere mentioned this pull request Nov 8, 2025
Merged
@trop
Copy link
Contributor

trop bot commented Nov 8, 2025

@codebytere has manually backported this PR to "38-x-y", please check out #48853

@trop trop bot added in-flight/38-x-y merged/39-x-y PR was merged to the "39-x-y" branch. merged/38-x-y PR was merged to the "38-x-y" branch. and removed needs-manual-bp/38-x-y in-flight/39-x-y in-flight/38-x-y labels Nov 8, 2025
nilayarya pushed a commit to nilayarya/electron that referenced this pull request Nov 21, 2025
@codebytere
feat: enable resetting accent color (electron#48274)
6d1744b
nilayarya added a commit to nilayarya/electron that referenced this pull request Nov 21, 2025
@nilayarya
feat: enable resetting accent color (electron#48274)
7cd590e
nilayarya added a commit to nilayarya/electron that referenced this pull request Nov 21, 2025
@nilayarya
feat: enable resetting accent color (electron#48274)
13f7741
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@deepak1556 deepak1556 Awaiting requested review from deepak1556

@mlaurencin mlaurencin Awaiting requested review from mlaurencin

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

@itsananderson itsananderson Awaiting requested review from itsananderson

@erickzhao erickzhao Awaiting requested review from erickzhao

Assignees

No one assigned

Labels

api-review/approved ✅ merged/38-x-y PR was merged to the "38-x-y" branch. merged/39-x-y PR was merged to the "39-x-y" branch. needs-manual-bp/37-x-y semver/minor backwards-compatible functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Windows: accent color cannot be reset without a restart

8 participants

@codebytere @ckerr @bpasero @itsananderson @jkleinsc @MarshallOfSound @erickzhao