fix: ensure dragging works again after emitting contextmenu event#48199
Merged
fix: ensure dragging works again after emitting contextmenu event#48199
Conversation
63d3361 to
cf387d2
Compare
deepak1556
approved these changes
Aug 28, 2025
jkleinsc
approved these changes
Aug 29, 2025
|
Release Notes Persisted
|
This was referenced Aug 29, 2025
Contributor
|
I have automatically backported this PR to "38-x-y", please check out #48224 |
Contributor
|
I have automatically backported this PR to "36-x-y", please check out #48225 |
Contributor
|
I have automatically backported this PR to "37-x-y", please check out #48226 |
codebytere
added a commit
that referenced
this pull request
Sep 5, 2025
dodolalorc
pushed a commit
to dodolalorc/electron
that referenced
this pull request
Sep 11, 2025
kigh-ota
pushed a commit
to kigh-ota/electron
that referenced
this pull request
Sep 30, 2025
nilayarya
pushed a commit
to nilayarya/electron
that referenced
this pull request
Nov 21, 2025
nilayarya
added a commit
to nilayarya/electron
that referenced
this pull request
Nov 21, 2025
nilayarya
added a commit
to nilayarya/electron
that referenced
this pull request
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #48179.
Fixes an issue where dragging sometimes didn't work after the
contextmenuevent was emitted. This happened becauseWM_RBUTTONUPcan be racy with the mousehandler, so the call toelectron::api::WebContents::SetDisableDraggableRegions(false)didn't always happen as expected. Fix this by consolidating logic intoElectronDesktopWindowTreeHostWin::HandleMouseEvent.Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where dragging sometimes didn't work after the
contextmenuevent was emitted.