Skip to content

fix: showMessageDialog should center dialog to parent#48181

Merged
codebytere merged 1 commit intomainfrom
fix-window-relative-dialog
Aug 29, 2025
Merged

fix: showMessageDialog should center dialog to parent#48181
codebytere merged 1 commit intomainfrom
fix-window-relative-dialog

Conversation

@codebytere
Copy link
Copy Markdown
Member

@codebytere codebytere commented Aug 27, 2025 •
edited
Loading

Description of Change

Closes #23001.

Fixes an issue where dialog.showMessageDialog showed a window incorrectly centered to monitor instead of parent window when passed.

Before

Screenshot 2025-08-27 at 10 50 56 AM

After

Screenshot 2025-08-27 at 10 53 11 AM

Checklist

Release Notes

Notes: Fixed an issue where dialog.showMessageDialog showed a window incorrectly centered to monitor instead of parent window when passed.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/36-x-y PR should also be added to the "36-x-y" branch. target/37-x-y PR should also be added to the "37-x-y" branch. target/38-x-y PR should also be added to the "38-x-y" branch. labels Aug 27, 2025
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Aug 27, 2025
deepak1556
deepak1556 approved these changes Aug 27, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Aug 28, 2025
@codebytere codebytere merged commit 7373173 into main Aug 29, 2025
160 of 163 checks passed
@codebytere codebytere deleted the fix-window-relative-dialog branch August 29, 2025 07:56
@release-clerk
Copy link
Copy Markdown

release-clerk bot commented Aug 29, 2025

Release Notes Persisted

Fixed an issue where dialog.showMessageDialog showed a window incorrectly centered to monitor instead of parent window when passed.

This was referenced Aug 29, 2025
Merged
Merged
Merged
@trop
Copy link
Copy Markdown
Contributor

trop bot commented Aug 29, 2025

I have automatically backported this PR to "37-x-y", please check out #48213

@trop
Copy link
Copy Markdown
Contributor

trop bot commented Aug 29, 2025

I have automatically backported this PR to "36-x-y", please check out #48214

@trop trop bot removed the target/37-x-y PR should also be added to the "37-x-y" branch. label Aug 29, 2025
@trop
Copy link
Copy Markdown
Contributor

trop bot commented Aug 29, 2025

I have automatically backported this PR to "38-x-y", please check out #48215

@trop trop bot added in-flight/36-x-y in-flight/38-x-y merged/38-x-y PR was merged to the "38-x-y" branch. and removed target/36-x-y PR should also be added to the "36-x-y" branch. target/38-x-y PR should also be added to the "38-x-y" branch. in-flight/38-x-y labels Aug 29, 2025
@trop trop bot removed the in-flight/37-x-y label Sep 5, 2025
@trop trop bot added merged/37-x-y PR was merged to the "37-x-y" branch. merged/36-x-y PR was merged to the "36-x-y" branch. and removed in-flight/36-x-y labels Sep 5, 2025
codebytere added a commit that referenced this pull request Sep 5, 2025
@codebytere
fix: showMessageDialog should center dialog to parent (#48181)
c24743b
dodolalorc pushed a commit to dodolalorc/electron that referenced this pull request Sep 11, 2025
@codebytere @dodolalorc
fix: showMessageDialog should center dialog to parent (electron#48181)
3b6b0e1
kigh-ota pushed a commit to kigh-ota/electron that referenced this pull request Sep 30, 2025
@codebytere @kigh-ota
fix: showMessageDialog should center dialog to parent (electron#48181)
ab5c58f
nilayarya pushed a commit to nilayarya/electron that referenced this pull request Nov 21, 2025
@codebytere
fix: showMessageDialog should center dialog to parent (electron#48181)
06b032b
nilayarya added a commit to nilayarya/electron that referenced this pull request Nov 21, 2025
@nilayarya
fix: showMessageDialog should center dialog to parent (electron#48181)
f1ebf63
nilayarya added a commit to nilayarya/electron that referenced this pull request Nov 21, 2025
@nilayarya
fix: showMessageDialog should center dialog to parent (electron#48181)
549107f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

@dsanders11 dsanders11 Awaiting requested review from dsanders11

Assignees

No one assigned

Labels

merged/36-x-y PR was merged to the "36-x-y" branch. merged/37-x-y PR was merged to the "37-x-y" branch. merged/38-x-y PR was merged to the "38-x-y" branch. semver/patch backwards-compatible bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Dialogs aren't centered to the window when calling showMessageBox(win, ...)

3 participants

@codebytere @jkleinsc @deepak1556