Skip to content

build: use new 7z command line switch#48136

Merged
jkleinsc merged 1 commit intomainfrom
use-expand-archive
Aug 20, 2025
Merged

build: use new 7z command line switch#48136
jkleinsc merged 1 commit intomainfrom
use-expand-archive

Conversation

@jkleinsc
Copy link
Copy Markdown
Member

@jkleinsc jkleinsc commented Aug 20, 2025 •
edited
Loading

Description of Change

Our Github Actions Windows runners were recently updated to https://github.com/actions/runner/releases/tag/v2.328.0. This ended up pulling in a newer version of 7zip which has changed the flag we use from -snld to -snld20: https://github.com/ip7z/7zip/releases/tag/25.01

Checklist

Release Notes

Notes: none

@jkleinsc jkleinsc force-pushed the use-expand-archive branch from 953f40e to 0061e7c Compare August 20, 2025 20:08
@jkleinsc jkleinsc force-pushed the use-expand-archive branch from 0061e7c to 619af41 Compare August 20, 2025 20:12
@jkleinsc jkleinsc changed the title build: use expand-archive instead of 7z build: use new 7z command line switch Aug 20, 2025
@jkleinsc jkleinsc added fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases target/35-x-y PR should also be added to the "35-x-y" branch. target/36-x-y PR should also be added to the "36-x-y" branch. target/37-x-y PR should also be added to the "37-x-y" branch. target/38-x-y PR should also be added to the "38-x-y" branch. labels Aug 20, 2025
@jkleinsc jkleinsc marked this pull request as ready for review August 20, 2025 20:35
@jkleinsc jkleinsc requested a review from a team as a code owner August 20, 2025 20:35
@jkleinsc jkleinsc merged commit 1044fe6 into main Aug 20, 2025
63 of 64 checks passed
@jkleinsc jkleinsc deleted the use-expand-archive branch August 20, 2025 21:05
@release-clerk
Copy link
Copy Markdown

release-clerk Bot commented Aug 20, 2025

No Release Notes

This was referenced Aug 20, 2025
Merged
Merged
Merged
Merged
@trop
Copy link
Copy Markdown
Contributor

trop Bot commented Aug 20, 2025

I have automatically backported this PR to "35-x-y", please check out #48137

@trop
Copy link
Copy Markdown
Contributor

trop Bot commented Aug 20, 2025

I have automatically backported this PR to "37-x-y", please check out #48138

@trop trop Bot removed the target/35-x-y PR should also be added to the "35-x-y" branch. label Aug 20, 2025
@trop
Copy link
Copy Markdown
Contributor

trop Bot commented Aug 20, 2025

I have automatically backported this PR to "38-x-y", please check out #48139

@trop
Copy link
Copy Markdown
Contributor

trop Bot commented Aug 20, 2025

I have automatically backported this PR to "36-x-y", please check out #48140

@trop trop Bot added in-flight/37-x-y in-flight/38-x-y in-flight/36-x-y and removed target/37-x-y PR should also be added to the "37-x-y" branch. labels Aug 20, 2025
@trop trop Bot added merged/35-x-y PR was merged to the "35-x-y" branch. merged/36-x-y PR was merged to the "36-x-y" branch. merged/38-x-y PR was merged to the "38-x-y" branch. merged/37-x-y PR was merged to the "37-x-y" branch. and removed target/38-x-y PR should also be added to the "38-x-y" branch. target/36-x-y PR should also be added to the "36-x-y" branch. in-flight/35-x-y in-flight/36-x-y in-flight/38-x-y in-flight/37-x-y labels Aug 20, 2025
kigh-ota pushed a commit to kigh-ota/electron that referenced this pull request Sep 30, 2025
@jkleinsc @kigh-ota
build: use new 7z command line switch (electron#48136)
3030491 
-snld20 replaces -snld
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VerteDinde VerteDinde VerteDinde approved these changes

Assignees

No one assigned

Labels

fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases merged/35-x-y PR was merged to the "35-x-y" branch. merged/36-x-y PR was merged to the "36-x-y" branch. merged/37-x-y PR was merged to the "37-x-y" branch. merged/38-x-y PR was merged to the "38-x-y" branch. semver/none

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jkleinsc @VerteDinde