fix: avoid deprecated login item methods#48090
Merged
VerteDinde merged 1 commit intomainfrom Aug 18, 2025
Merged
Conversation
codebytere
approved these changes
Aug 16, 2025
VerteDinde
approved these changes
Aug 17, 2025
|
Release Notes Persisted
|
This was referenced Aug 18, 2025
Contributor
|
I have automatically backported this PR to "38-x-y", please check out #48094 |
Contributor
|
I have automatically backported this PR to "36-x-y", please check out #48095 |
Contributor
|
I have automatically backported this PR to "37-x-y", please check out #48096 |
kigh-ota
pushed a commit
to kigh-ota/electron
that referenced
this pull request
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There appears to be a deadlock condition inside
LSSharedFileListCopySnapshotwhich is called deep within the deprecated codepath on macOS. This change should ensure that the deprecated codepath is not followed 99% of the time.Honestly we should probably just remove this deprecated code, but for now this is a backport safe variant that should fix the deadlock.
Notes: Fixed potential deadlock inside
app.getLoginItemSettingson macOS