fix: system accent color parsing hex order#48085
Merged
codebytere merged 1 commit intomainfrom Aug 19, 2025
Merged
Conversation
60b1ede to
73584b7
Compare
3 tasks
jkleinsc
approved these changes
Aug 18, 2025
|
Release Notes Persisted
|
This was referenced Aug 19, 2025
Contributor
|
I have automatically backported this PR to "37-x-y", please check out #48107 |
Contributor
|
I have automatically backported this PR to "38-x-y", please check out #48108 |
Contributor
|
I have automatically backported this PR to "36-x-y", please check out #48109 |
2 tasks
5 tasks
2 tasks
kigh-ota
pushed a commit
to kigh-ota/electron
that referenced
this pull request
Sep 30, 2025
fix: system accent color parsing
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #48086
Closes https://github.com/electron/electron/issues
Refs #47741.
Fixes an issue where the accent color would be accidentally inverted when set to match the system color. This could be seen if you chose e.g. an orange, whose color opposite is blue; the window would have a blue border in that case. This happened because
DwmGetColorizationColorreturns a color formatted0xAARRGGBB, and the parsing performed here usedGet{R|G|B}Valueto parse the color into aCOLORREF. From documentation:Switch to pulling the color from the windows registry, which does not require extra conversion to ensure the color is in the right format.
cc @bpasero
Tested to ensure the color updates correctly with settings change.
Checklist
npm testpassesRelease Notes
Notes: Fixes an issue where the accent color would be accidentally inverted when set to match the system color.