fix: webContent.fromId should be number instead of string#48059
Merged
jkleinsc merged 1 commit intoelectron:mainfrom Aug 22, 2025
Merged
fix: webContent.fromId should be number instead of string#48059jkleinsc merged 1 commit intoelectron:mainfrom
jkleinsc merged 1 commit intoelectron:mainfrom
Conversation
codebytere
approved these changes
Aug 14, 2025
|
No Release Notes |
dodolalorc
pushed a commit
to dodolalorc/electron
that referenced
this pull request
Sep 11, 2025
kigh-ota
pushed a commit
to kigh-ota/electron
that referenced
this pull request
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
The fromId defined in the file accepts a string arg, while the api docs are number, the native binding also wants a int32.
Release Notes
Notes: none