fix: BrowserWindow add the same BrowserView#48053
Merged
codebytere merged 1 commit intoelectron:mainfrom Aug 28, 2025
Merged
Conversation
codebytere
requested changes
Aug 12, 2025
Member
codebytere
left a comment
There was a problem hiding this comment.
Please add a test for this! Also, could you please open a simple bug report and link it to this PR?
Contributor
Author
OK |
codebytere
reviewed
Aug 12, 2025
3db2c09 to
21ad54f
Compare
Contributor
Author
|
nikwen
previously requested changes
Aug 12, 2025
codebytere
approved these changes
Aug 14, 2025
Member
|
@mai-121 could you please rebase this? |
836b6fb to
09a0845
Compare
Contributor
Author
done |
09a0845 to
ebcafd0
Compare
|
Release Notes Persisted
|
This was referenced Aug 28, 2025
Contributor
|
I have automatically backported this PR to "37-x-y", please check out #48200 |
Contributor
|
I have automatically backported this PR to "38-x-y", please check out #48201 |
codebytere
pushed a commit
that referenced
this pull request
Sep 5, 2025
fix: BrowserWindow add the same BrowserView (#48057)
dodolalorc
pushed a commit
to dodolalorc/electron
that referenced
this pull request
Sep 11, 2025
fix: BrowserWindow add the same BrowserView (electron#48057)
kigh-ota
pushed a commit
to kigh-ota/electron
that referenced
this pull request
Sep 30, 2025
fix: BrowserWindow add the same BrowserView (electron#48057)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #48057
Fixed addBrowserView to prevent unnecessary removal and re-adding of the same BrowserView.
Checklist
npm testpassesRelease Notes
Notes: Fixed addBrowserView to prevent unnecessary removal and re-adding of the same BrowserView.