fix: crash on window.close() with webContents on blur#47933
Merged
codebytere merged 1 commit intomainfrom Aug 4, 2025
Merged
Conversation
window.close() with webContents on blur
6d9ea37 to
9e7a36e
Compare
deepak1556
approved these changes
Aug 2, 2025
|
Release Notes Persisted
|
This was referenced Aug 4, 2025
Contributor
|
I have automatically backported this PR to "38-x-y", please check out #47952 |
Contributor
|
I have automatically backported this PR to "36-x-y", please check out #47953 |
Contributor
|
I have automatically backported this PR to "37-x-y", please check out #47954 |
kigh-ota
pushed a commit
to kigh-ota/electron
that referenced
this pull request
Sep 30, 2025
…7933) fix: crash on window.close with WebContentsView on blur
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #47830.
it's possible that
inspectable_web_contents_is null in some cases. In the above bug, the WebContentsView's webContents callswindow.close(), which causes the "blur" event to be emitted onwebContents. When the user handles the event in the callback,inspectable_web_contents_can already be gone, aswindow.close()causes asynchronous destruction.Checklist
npm testpassesRelease Notes
Notes: Fixed a crash when calling some
webContentsfunctions afterwindow.close().