Skip to content

fix: webContents.downloadURL() did not support referer header#47625

Merged
codebytere merged 1 commit intoelectron:mainfrom
xufuhang:fix/download-url-referer
Jul 23, 2025
Merged

fix: webContents.downloadURL() did not support referer header#47625
codebytere merged 1 commit intoelectron:mainfrom
xufuhang:fix/download-url-referer

Conversation

@xufuhang
Copy link
Contributor

@xufuhang xufuhang commented Jul 1, 2025 •
edited
Loading

Description of Change

This PR fixes an issue where the Referer HTTP header was not being correctly applied when using the webContents.downloadURL() API.

The previous implementation added all headers, including Referer, through the generic add_request_header method. However, Referer is a special header that cannot be set via the generic add_request_header method. Instead, the download system requires the referrer to be set specifically via download_params->set_referrer().

This change adds logic to specifically detect the Referer header (case-insensitively) from the options and sets it using the correct method, ensuring it is properly handled during the download request. Other headers continue to be processed as before.

Before this PR:

After this PR:

Checklist

Release Notes

Notes: Fixed a bug where the Referer header was not being set correctly when using webContents.downloadURL().

@welcome
Copy link

welcome bot commented Jul 1, 2025

💖 Thanks for opening this pull request! 💖

Semantic PR titles

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Commit signing

This repo enforces commit signatures for all incoming PRs.
To sign your commits, see GitHub's documentation on Telling Git about your signing key.

PR tips

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jul 1, 2025
@xufuhang xufuhang force-pushed the fix/download-url-referer branch 2 times, most recently from b7a5e0e to 2152523 Compare July 3, 2025 04:02
@codebytere codebytere self-requested a review July 3, 2025 20:23
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Jul 8, 2025
codebytere
codebytere approved these changes Jul 14, 2025
View reviewed changes
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you rebase this when you have a moment?

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/36-x-y PR should also be added to the "36-x-y" branch. target/37-x-y PR should also be added to the "37-x-y" branch. target/38-x-y PR should also be added to the "38-x-y" branch. labels Jul 14, 2025
@xufuhang xufuhang force-pushed the fix/download-url-referer branch from 2152523 to 501f1ec Compare July 14, 2025 08:18
@xufuhang
Copy link
Contributor Author

xufuhang commented Jul 14, 2025

Thanks! Could you rebase this when you have a moment?

Thanks! I've just rebased the branch.

@xufuhang
Copy link
Contributor Author

xufuhang commented Jul 16, 2025

Hi @codebytere , thank you for approving this PR. I noticed that the merge was blocked by some failing CI checks. I've looked into the logs for the jobs, and the failures appear to be in areas unrelated to my code changes. It seems like they might be flaky.

Would it be possible to get a re-run of the CI, or could you take a look when you have a chance?

@codebytere
Copy link
Member

codebytere commented Jul 16, 2025

@xufuhang could you please verify your commit? It's a project policy.

@xufuhang xufuhang force-pushed the fix/download-url-referer branch from 501f1ec to a3c072a Compare July 17, 2025 03:29
@xufuhang
Copy link
Contributor Author

xufuhang commented Jul 17, 2025

@xufuhang could you please verify your commit? It's a project policy.

Hi @codebytere , I've just signed the commit, thank you for the guidance! It seems the workflows are now awaiting your approval to run. Could you please take a look when you have a moment?

@codebytere
Copy link
Member

codebytere commented Jul 21, 2025

@xufuhang the mac failures will be solved with rebase

@xufuhang
fix: webContents.downloadURL() did not support referer header
7098b2c 
Signed-off-by: xufuhang <576484918@qq.com>
@xufuhang xufuhang force-pushed the fix/download-url-referer branch from 30ca923 to 7098b2c Compare July 22, 2025 03:23
@xufuhang
Copy link
Contributor Author

xufuhang commented Jul 22, 2025

@xufuhang the mac failures will be solved with rebase

Hi @codebytere, I've just rebased the branch. It seems the workflows are now awaiting your approval to run. Could you please take a look when you have a moment?

@xufuhang
Copy link
Contributor Author

xufuhang commented Jul 23, 2025

Hi @codebytere , thank you for approving. I've looked into the logs for the jobs, and the failures appear to be in areas unrelated to my code changes. Could you take a look again when you have a chance?

@codebytere codebytere merged commit b39a1fb into electron:main Jul 23, 2025
55 of 57 checks passed
@welcome
Copy link

welcome bot commented Jul 23, 2025

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk
Copy link

release-clerk bot commented Jul 23, 2025

Release Notes Persisted

Fixed a bug where the Referer header was not being set correctly when using webContents.downloadURL().

This was referenced Jul 23, 2025
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Jul 23, 2025

I have automatically backported this PR to "37-x-y", please check out #47865

@trop trop bot removed the target/37-x-y PR should also be added to the "37-x-y" branch. label Jul 23, 2025
@trop
Copy link
Contributor

trop bot commented Jul 23, 2025

I have automatically backported this PR to "36-x-y", please check out #47866

@trop
Copy link
Contributor

trop bot commented Jul 23, 2025

I have automatically backported this PR to "38-x-y", please check out #47867

@trop trop bot added in-flight/36-x-y in-flight/38-x-y merged/36-x-y PR was merged to the "36-x-y" branch. merged/38-x-y PR was merged to the "38-x-y" branch. and removed target/36-x-y PR should also be added to the "36-x-y" branch. target/38-x-y PR should also be added to the "38-x-y" branch. in-flight/36-x-y in-flight/38-x-y labels Jul 23, 2025
@trop trop bot added merged/37-x-y PR was merged to the "37-x-y" branch. and removed in-flight/37-x-y labels Jul 31, 2025
kigh-ota pushed a commit to kigh-ota/electron that referenced this pull request Sep 30, 2025
@xufuhang @kigh-ota
fix: webContents.downloadURL() did not support referer header (elec…
5f2c916 
…tron#47625)

Signed-off-by: xufuhang <576484918@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codebytere codebytere codebytere approved these changes

Assignees

No one assigned

Labels

merged/36-x-y PR was merged to the "36-x-y" branch. merged/37-x-y PR was merged to the "37-x-y" branch. merged/38-x-y PR was merged to the "38-x-y" branch. semver/patch backwards-compatible bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xufuhang @codebytere