fix: crash calling Fetch.continueResponse with WebContentsView#47434
Merged
codebytere merged 1 commit intomainfrom Jun 11, 2025
Merged
fix: crash calling Fetch.continueResponse with WebContentsView#47434codebytere merged 1 commit intomainfrom
Fetch.continueResponse with WebContentsView#47434codebytere merged 1 commit intomainfrom
Conversation
b3ce9c8 to
73aece3
Compare
deepak1556
approved these changes
Jun 10, 2025
ckerr
approved these changes
Jun 10, 2025
|
Release Notes Persisted
|
This was referenced Jun 11, 2025
Contributor
|
I have automatically backported this PR to "36-x-y", please check out #47442 |
Contributor
|
I have automatically backported this PR to "35-x-y", please check out #47443 |
Contributor
|
I have automatically backported this PR to "37-x-y", please check out #47444 |
kigh-ota
pushed a commit
to kigh-ota/electron
that referenced
this pull request
Sep 30, 2025
…lectron#47434) fix: crash calling Fetch.continueResponse with WebContentsView
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #46109
Fixes an issue where calling
Fetch.continueResponsevia debugger withWebContentsViewcould cause a crash. Some light investigation showed thatRenderFrameDevToolsAgentHost::{Connect|Disconnect}WebContents()relied on the primary main frame of the passedwebContentsto attach, but it might be the case that theRenderFrameHostat hand is not in its primary main frame. If the newRenderFrameHostis not the primary main frame, we don't want to reconnect otherwise we'll end up potentially trying to reconnect to aRenderFrameHostthat already has aDevToolsAgentHostassociated with it.See also this known bug in Chromium.
Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where calling
Fetch.continueResponsevia debugger withWebContentsViewcould cause a crash.