fix: silent printing of PDFs with webContents.print#47378
Merged
Conversation
webContents.print
deepak1556
approved these changes
Jun 6, 2025
jkleinsc
approved these changes
Jun 6, 2025
|
Release Notes Persisted
|
Contributor
|
I was unable to backport this PR to "35-x-y" cleanly; |
Contributor
|
I was unable to backport this PR to "36-x-y" cleanly; |
Contributor
|
I have automatically backported this PR to "37-x-y", please check out #47397 |
Contributor
|
@codebytere has manually backported this PR to "36-x-y", please check out #47624 |
kigh-ota
pushed a commit
to kigh-ota/electron
that referenced
this pull request
Sep 30, 2025
fix: silent printing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #47272.
Fixes an issue where printing PDFs with
webContents.print({ silent: true })would fail. This happened after the switch to OOP owing to this code which tried to composite any modifiable jobs. Under non-silent circumstances, calls to get settings from the user correctly set any non-html jobs to non-modifiable, but this logic was bypassed in silent printing and so PDF jobs were mistakenly marked modifiable.Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where printing PDFs with
webContents.print({ silent: true })would fail.